-
Notifications
You must be signed in to change notification settings - Fork 56
Auto-restart when network reset happens #244
Comments
Implementation notes:
|
@frol I believe that genesis time may not be properly updated right now. It is safer to always require the genesis block and obtain its hash to see whether that has changed. |
@bowenwang1996 That is |
Yes |
Updated my post above. |
@frol why do you need to check it 6 times before restarting? |
@bowenwang1996 resync is quite an expensive task, so I would prefer to give a minute before dropping the previously synced state. |
@bowenwang1996 @frol I can not find |
@icerove It was introduced "recently" (near/nearcore#2248), so it did not make to the example output. It is there. |
Let's not drop old data at all. We should keep it in the explorer. |
Well, Explorer is not self-sufficient, it relies on the data to be available from the node. Also, I think it is going to be confusing if you can see a blocks and transactions that don't exist on the current network. We can archive the data (instead of removing the DB, let's rename the file, and we don't actually need to wait a minute before doing so, as I proposed above to avoid dropping the data too fast, since having the backup we can revert the state if needed [updated the implementation notes above]). |
It's not confusing if you think that it's the same network, just was re-snappshotted. we also want to have old stuff for better metrics, from total tx over time, total blocks over time, total new accounts over time, etc. CC @potatodepaulo @vgrichina |
@ilblackdragon why people would not expect to do RPC call to fetch a block/transaction and receive the same output as they see on Explorer? |
Resolved in #313 |
Story
As a user who uses betanet and devnet, I would like to have auto-restart for devnet and betanet explorer when a network reset happens. It suffices to detect whether genesis hash changed periodically.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: