Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synth-bench: make option specifying TPS more intuitive + consistent #12835

Open
mooori opened this issue Jan 29, 2025 · 0 comments · May be fixed by #12839
Open

synth-bench: make option specifying TPS more intuitive + consistent #12835

mooori opened this issue Jan 29, 2025 · 0 comments · May be fixed by #12839
Assignees
@ssavenko-near
Labels
A-benchmark Area: performance benchmarks C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on.

Comments

@mooori
Copy link
Contributor

mooori commented Jan 29, 2025

benchmark_mpc_sign takes a transactions_per_second option and converts that to an interval:

nearcore/benchmarks/synth-bm/src/contract.rs

Lines 64 to 65 in a33310b

let mut interval =
time::interval(Duration::from_micros(1_000_000 / args.transactions_per_second));

Commands for account creation and native transfer benchmarking take option interval_duration_micros. These should be changed to take transactions_per_second like benchmark_mpc_sign. That's more convenient for user of the CLI.
@mooori mooori added A-benchmark Area: performance benchmarks C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. labels Jan 29, 2025
@mooori mooori changed the title synth-bench: make option speciying TPS more intuitive + consistent synth-bench: make option specifying TPS more intuitive + consistent Jan 29, 2025
@ssavenko-near ssavenko-near self-assigned this Jan 29, 2025
ssavenko-near added a commit that referenced this issue Jan 30, 2025
@ssavenko-near
replace interval_duration_micros by requests_per_second as an argumen…
ee676af 
…t for native token transaction benchmark

Issue [12835](#12835).
Using "requests-per-second" instead of suggested "transactions_per_second" as this value can be used to limit the rate of the other requests to the network as well (client data sync for example).
Renamed the corresponding parameter in the `bencmark_mpc_sign` as well.
@ssavenko-near ssavenko-near linked a pull request Jan 30, 2025 that will close this issue
Draft
@ssavenko-near ssavenko-near linked a pull request Jan 30, 2025 that will close this issue
replace interval_duration_micros by requests_per_second as an argument to benchmark_native_transfers #12839
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssavenko-near ssavenko-near

Labels
A-benchmark Area: performance benchmarks C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on.
Projects
None yet
Milestone
No milestone
2 participants
@mooori @ssavenko-near