Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View state returns error if key is not a string #1927

Closed
bowenwang1996 opened this issue Jan 6, 2020 · 1 comment
Closed

View state returns error if key is not a string #1927

bowenwang1996 opened this issue Jan 6, 2020 · 1 comment
Assignees
@bowenwang1996
Labels
A-RPC Area: rpc

Comments

@bowenwang1996
Copy link
Collaborator

When we have some binary value as a key in storage, state viewing rpc will return an error because it cannot be converted directly to string. We should consider encoding keys and values in base58.
@bowenwang1996 bowenwang1996 self-assigned this Jan 6, 2020
@MaksymZavershynskyi MaksymZavershynskyi added the A-RPC Area: rpc label Jan 20, 2020
@frol
Copy link
Collaborator

frol commented Feb 13, 2020

Resolved in #2075

@frol frol closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bowenwang1996 bowenwang1996

Labels
A-RPC Area: rpc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frol @bowenwang1996 @MaksymZavershynskyi