Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionErrorKind doesn't provide index for ActionError #2012

Closed
evgenykuzyakov opened this issue Jan 23, 2020 · 2 comments
Closed

ActionErrorKind doesn't provide index for ActionError #2012

evgenykuzyakov opened this issue Jan 23, 2020 · 2 comments
Assignees
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc)

Comments

@evgenykuzyakov
Copy link
Collaborator

There are a lot of places where we throw ActionErrorKind and then use .into(). This doesn't provide the action index. I think we can fix it in Runtime::apply_action_receipt by checking if result.result.is_err() and it's an ActionError and then insert the actual action index into the error.

@evgenykuzyakov evgenykuzyakov added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Jan 23, 2020
@lexfrl
Copy link
Contributor

lexfrl commented Jan 24, 2020

@lexfrl lexfrl assigned evgenykuzyakov and unassigned lexfrl Jan 24, 2020
@MaksymZavershynskyi
Copy link
Contributor

Closing since the action index is in ActionError struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc)
Projects
None yet
Development

No branches or pull requests

3 participants