Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose balance-change events in a block #2036

Closed
bowenwang1996 opened this issue Jan 29, 2020 · 2 comments
Closed

expose balance-change events in a block #2036

bowenwang1996 opened this issue Jan 29, 2020 · 2 comments
Assignees
Labels
A-RPC Area: rpc C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high Priority: High

Comments

@bowenwang1996
Copy link
Collaborator

For a given block, we can query for each account the events that happen in that block, but there is no way to query all the events that change account balances for all the accounts that are touched in the block.

@bowenwang1996 bowenwang1996 added the A-RPC Area: rpc label Jan 29, 2020
@frol frol added C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high Priority: High labels Jan 30, 2020
@frol
Copy link
Collaborator

frol commented Mar 17, 2020

Since #2253 there is a new RPC endpoint to query a list of accounts with a type of the state change (e.g. account_touched) touched within a given block.

Since #2148 the changes RPC exposes detailed information about the state change (a cause and a new value).

#2264 will allow querying RPC for state changes of the same type (e.g. account_changes) for a list of account_ids.

@bowenwang1996 Do those PRs resolve this issue? Is there anything extra we want to expose?

@bowenwang1996
Copy link
Collaborator Author

bowenwang1996 commented Mar 17, 2020

I believe they are sufficient.

@frol frol closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-RPC Area: rpc C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high Priority: High
Projects
None yet
Development

No branches or pull requests

2 participants