Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace actix-web for RPC #2057

Closed
MaksymZavershynskyi opened this issue Feb 2, 2020 · 1 comment
Closed

Replace actix-web for RPC #2057

MaksymZavershynskyi opened this issue Feb 2, 2020 · 1 comment
Assignees
Labels
A-RPC Area: rpc C-enhancement Category: An issue proposing an enhancement or a PR with one.
Milestone

Comments

@MaksymZavershynskyi
Copy link
Contributor

We are using actix-web for RPC, however we have experienced issues with stability and had some version upgrades break our tests. Also the status of actix-web is not well-defined. We should consider other frameworks:

@MaksymZavershynskyi MaksymZavershynskyi added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-RPC Area: rpc labels Feb 2, 2020
@ilblackdragon ilblackdragon added this to the Post MainNet milestone Mar 18, 2020
@frol
Copy link
Collaborator

frol commented May 8, 2021

I don't think actix-web is even close to being the main blame for the problem we usually have with RPC. We usually hit internal limitations like slow trie iteration or exhausted actix mailbox much earlier than we hit issues with actix-web.

@frol frol closed this as completed May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-RPC Area: rpc C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

3 participants