Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master tests are broken #2081

Closed
MaksymZavershynskyi opened this issue Feb 4, 2020 · 9 comments
Closed

master tests are broken #2081

MaksymZavershynskyi opened this issue Feb 4, 2020 · 9 comments
Assignees
Labels
A-CI Area: Continuous Integration P-high Priority: High

Comments

@MaksymZavershynskyi
Copy link
Contributor

Tests on master branch are broken which prevents us from merging PRs into it.
To reproduce:

git fetch --all & git checkout master
cargo test --all

Expected the tests to pass, but observe the following:

running 19 tests
[2020-02-04T14:32:26Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_challenges.9d5R9F9ekJTT/data" path, will be creating new store database
[2020-02-04T14:32:26Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_validator_get_validator_info.hpr5kogtw6is/data" path, will be creating new store database
[2020-02-04T14:32:26Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_challenges.2zF6g4N31Nwb/data" path, will be creating new store database
[2020-02-04T14:32:26Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_validator_get_validator_info.Foy3ci2mYUKB/data" path, will be creating new store database
[2020-02-04T14:32:26Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_challenges.CP9fZpL3hW9b/data" path, will be creating new store database
[2020-02-04T14:32:26Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_validator_stake_change_multiple_times.Dne7beI6W3au/data" path, will be creating new store database
[2020-02-04T14:32:26Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_challenges.CHhh3RfjgZ2D/data" path, will be creating new store database
test config::test::test_deserialize_state ... ok
[2020-02-04T14:32:27Z INFO  near] Did not find "/var/folders/0l/p6x6kd4x2ql3h2qbr9jwykph0000gn/T/test_key_value_changes.7pTbCgKZOJA3/data" path, will be creating new store database
thread panicked while processing panic. aborting.
error: process didn't exit successfully: `/Users/maksymzavershynskyi/Projects/nearcore/target/debug/deps/near-c9886a840bfc0db9` (signal: 4, SIGILL: illegal instruction)
@MaksymZavershynskyi
Copy link
Contributor Author

MaksymZavershynskyi commented Feb 4, 2020

It is not clear which test throws panic. Marking it as a blocker for stuff that we need to do for the EthDenver.

@MaksymZavershynskyi MaksymZavershynskyi added the P-critical Priority: critical label Feb 4, 2020
@MaksymZavershynskyi MaksymZavershynskyi added the A-CI Area: Continuous Integration label Feb 4, 2020
@bowenwang1996
Copy link
Collaborator

Does this appear on some specific branch? CI passes on latest commit on master https://github.com/nearprotocol/nearcore/commits/master

@MaksymZavershynskyi
Copy link
Contributor Author

Does this appear on some specific branch? CI passes on latest commit on master https://github.com/nearprotocol/nearcore/commits/master

It fails locally (see the description) and it fails on a PR that is supposed to be a no-op blocking it: #2064

@MaksymZavershynskyi
Copy link
Contributor Author

MaksymZavershynskyi commented Feb 4, 2020

From @ailisp :

For local test rpc_node test fail. from backtrace it seems fail to start client actor

@ailisp Do you know why it fails to start the client actor?

@MaksymZavershynskyi
Copy link
Contributor Author

@ailisp Did you have a chance to create a cherrypick for ulimit?

@MaksymZavershynskyi
Copy link
Contributor Author

https://app.zenhub.com/workspaces/development-5cea2bcf78297c385cf0ec81/issues/nearprotocol/nearcore/2072 Was merged so it is not a blocker anymore. Removing from EthDenver Epic and lowering priority to P1.

@MaksymZavershynskyi MaksymZavershynskyi added P-high Priority: High and removed P-critical Priority: critical labels Feb 5, 2020
@MaksymZavershynskyi
Copy link
Contributor Author

Leaving @ailisp as the only assignee since he is working on a fix.

@ailisp
Copy link
Member

ailisp commented Feb 5, 2020

Fixed in #2085
However gitlab mirror master is broken, will confirm this fix when i reset the mirror

@ailisp
Copy link
Member

ailisp commented Feb 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Continuous Integration P-high Priority: High
Projects
None yet
Development

No branches or pull requests

3 participants