Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reconstructing a chunk, receipts and encrypted secret shares are not stored into the cache entry #2110

Open
SkidanovAlex opened this issue Feb 7, 2020 · 1 comment
Assignees
Labels
A-chain Area: Chain, client & related C-bug Category: This is a bug
Milestone

Comments

@SkidanovAlex
Copy link
Collaborator

SkidanovAlex commented Feb 7, 2020

When a node that tracks a shard fully reconstructs a chunk, it sets all the parts in the cache entry:

 for (part_ord, part_entry) in entry.parts.iter() 

 { encoded_chunk.content.parts[*part_ord as usize] = Some(part_entry.part.clone()); } 

But it doesn't appear to be also setting the receipts.
Thus, if the original creator of the chunk is offline, and for some shard no receipts were distributed, when network participants resort to fetching state from participants that follow the shard, such participants will not serve the receipts.

Similarly, once Randomness is finished, the same problem will exist for the encrypted secret shares.

@SkidanovAlex SkidanovAlex added C-bug Category: This is a bug A-chain Area: Chain, client & related labels Feb 7, 2020
@SkidanovAlex SkidanovAlex self-assigned this Feb 7, 2020
@SkidanovAlex SkidanovAlex added this to the Post MainNet milestone Mar 4, 2020
@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 1, 2021
@stale stale bot removed the S-stale label Jul 1, 2021
@akhi3030 akhi3030 removed the S-pinned label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chain Area: Chain, client & related C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants