Check max peer is not passed. #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfornet
requested review from
evgenykuzyakov,
MaksymZavershynskyi and
SkidanovAlex
as code owners
Closed
MaksymZavershynskyi
approved these changes
Dec 27, 2019
Codecov Report
@@ Coverage Diff @@
## staging #1897 +/- ##
===========================================
- Coverage 86.59% 86.51% -0.09%
===========================================
Files 166 167 +1
Lines 31572 31399 -173
===========================================
- Hits 27341 27165 -176
- Misses 4231 4234 +3
Continue to review full report at Codecov.
|
| runner.push(Action::CheckRoutingTable(0, vec![(1, vec![1]), (2, vec![2])])); | ||
| runner.push(Action::CheckRoutingTable(1, vec![(0, vec![0]), (2, vec![2])])); | ||
| runner.push(Action::CheckRoutingTable(2, vec![(1, vec![1]), (0, vec![0])])); | ||
| runner.push(Action::CheckRoutingTable(3, vec![])); |
There was a problem hiding this comment.
where is the number of peers checked?
There was a problem hiding this comment.
There routing table for peer 3 is empty since connection failed to establish.
runner.push(Action::CheckRoutingTable(3, vec![])); is enough to notice that peer3 have no route to any other peer in the system.
From other routing table we see that the triangle is still alive and new node is not connected. This test would fail before this PR.
mfornet
force-pushed
the
limit_max_peer
branch
from
5683e4c to
1cdcaf7
Compare
bowenwang1996
approved these changes
Dec 31, 2019
mfornet
force-pushed
the
limit_max_peer
branch
from
1cdcaf7 to
0d91c65
Compare
Remove some println
mfornet
force-pushed
the
limit_max_peer
branch
from
0c2e22d to
73d3868
Compare
SkidanovAlex
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Check max peer is not passed. * Solve racing incoming connections issues. * Add test * Update test * Fix fmt * Refactor network tests * Refactor account propagation + infinite loop Remove some println * Fix peer_recover * Move churn attack test out of routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make number of active peers don't exceed threshold from config.