tests_all_chunks_accepted #1956

Kouprin · 2020-01-15T00:31:17Z

Test test_all_chunks_accepted_1000_slow fails randomly within first 100 blocks.

BLOCK Block { header: BlockHeader { prev_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, inner_lite: BlockHeaderInnerLite { height: 42, epoch_id: EpochId(`A4ybjccrxCdwAMUz3QPyRQQpcU822KzQEs3SJBwUrHBZ`), next_epoch_id: EpochId(`J9NVNxoPG1dSPYPHoYGuR7UB3mhizGFL82ZbnYiyKP4m`), prev_state_root: `5mHWgS5VDpo2kyK7SuwgJosXY8ok2MwYma957YkXpSyk`, outcome_root: `2DoUX6XsDr5BxRN821ZxTLYYcQBzSSxPMTqMU4TLfu35`, timestamp: 1579048082659186000, next_bp_hash: `HdeigFECphBZzQfpXfoyGjc9oCNKLKd1vemb4KFzTgeK` }, inner_rest: BlockHeaderInnerRest { chunk_receipts_root: `EMqBidKyzZz5Dyv6vN4qh7AQ65jYpB6pizu1GkYQ4uEx`, chunk_headers_root: `Eg3ryvwhhRLmsFhdkF2Ry97iZm3fsxDUNAR3DezhPhuh`, chunk_tx_root: `2DoUX6XsDr5BxRN821ZxTLYYcQBzSSxPMTqMU4TLfu35`, chunks_included: 4, total_weight: Weight { num: 110207064750250000000 }, score: Weight { num: 107243760000250000000 }, validator_proposals: [], chunk_mask: [true, true, true, true], gas_price: 100, rent_paid: 0, validator_reward: 0, total_supply: 1000000000, challenges_result: [], last_quorum_pre_vote: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, last_quorum_pre_commit: `HE7J4sqW9ET6wCfnptfQbkdgaRqQWCfTq22G156fZYb9`, approvals: [Approval { parent_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, reference_hash: `Qe1cEkxnnPziESSc3UZvhmzWkkeZsTswG6JQZx7exuP`, signature: ed25519:4jHtNST8og7hnzPEQePxEWpuCcVEjigixaWmNPYRv3VaNrZyBaWeMNy3xGSHgJ2ZD28T1hKp79FUzhd18HjNRZpN, account_id: "test3.8" }, Approval { parent_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, reference_hash: `Qe1cEkxnnPziESSc3UZvhmzWkkeZsTswG6JQZx7exuP`, signature: ed25519:39BxH5vrJTfLcwtTujiEdBzVkZXEfXAPGznUy7Mm5TWtJ32abzQetRN5AJTHTwWg1DfaC2n13zoVT5x49sgcagds, account_id: "test3.5" }, Approval { parent_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, reference_hash: `Qe1cEkxnnPziESSc3UZvhmzWkkeZsTswG6JQZx7exuP`, signature: ed25519:25kAGFzJvEHjyDsZ3iQ2M1XJ3tB3pPCPtr72xPNBRjZwFQDLnujTqunv2thFKDJt4aY2JsndV3FQavWJbNRU4QLJ, account_id: "test3.6" }, Approval { parent_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, reference_hash: `7oMqBRhpj4pT9nLdETLhFqdVwmhaVAgJLiskrnR5pdr6`, signature: ed25519:S2kX1KGjM28mJPGcsbB4io8cEMbZJ5wXNLg5ZZiiyA7VYreTnsT3RQxXoSU3tNcqpwZjXX6YZokfJPk56QPaeCq, account_id: "test3.4" }, Approval { parent_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, reference_hash: `Qe1cEkxnnPziESSc3UZvhmzWkkeZsTswG6JQZx7exuP`, signature: ed25519:3bVzdxtPfauygguFRQTKBH4bBbBmqoG2jiMWSBxEJkQdTR69fAF7Cpw5wSVHViafgghhsBxExqb1VYtH1ytwufwH, account_id: "test3.3" }, Approval { parent_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, reference_hash: `Qe1cEkxnnPziESSc3UZvhmzWkkeZsTswG6JQZx7exuP`, signature: ed25519:2D2AqTTUXc5M9mgAGLHhga3ANReCQdHGb9BY9QmqeJzthJR3FrwJpGy9RJz4BHtgFtoQDb45SomrCMzQzTd3NMrt, account_id: "test3.7" }, Approval { parent_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, reference_hash: `Qe1cEkxnnPziESSc3UZvhmzWkkeZsTswG6JQZx7exuP`, signature: ed25519:yn8VCf89ixDpFnBSwohKQuYshuQr6NjMQ6bFEwfDV2NTh2vobeHw6mXNbJozzcWLfiEYqXA2Ux2vyXC1MSvKyLW, account_id: "test3.1" }] }, signature: ed25519:2JXNwyneyDWtwDeVoa98dQbsQdm9dTMYkzRj2FM6y5uv7BGfALhvHXJE76VqbbTM3aNwyoKbvPTh2KNra1dz5Thg, hash: `GNcvjRA3Xn9HfYVRCJVtKaVpyhAv1iFjCq6mCJTfpHB7` }, chunks: [ShardChunkHeader { inner: ShardChunkHeaderInner { prev_block_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, prev_state_root: `EgYyCMbQP5vfs65d8XLGoaWv3UGiVCEpvEvDt52UiKd8`, outcome_root: `11111111111111111111111111111111`, encoded_merkle_root: `45Ze8dvm5A4zbY3Au5YBDowRCJv66KoGzc6d7Xuosg37`, encoded_length: 8, height_created: 42, shard_id: 0, gas_used: 0, gas_limit: 1000000, rent_paid: 0, validator_reward: 0, balance_burnt: 0, outgoing_receipts_root: `8s41rye686T2ronWmFE38ji19vgeb6uPxjYMPt8y8pSV`, tx_root: `11111111111111111111111111111111`, validator_proposals: [] }, height_included: 42, signature: ed25519:1HXyN3FJkjTmFxeV22P364SkGTr9azyx1q2ZgPnGixiiwFJSK7LkkhcmggM9g7ea63VZk8AmZDprFnCKwJpeUG2, hash: ChunkHash(`9ccpHVmbTYQH57bA5AsTMd4NVDfWYWhtiGhSmuMVcfzG`) }, ShardChunkHeader { inner: ShardChunkHeaderInner { prev_block_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, prev_state_root: `EgYyCMbQP5vfs65d8XLGoaWv3UGiVCEpvEvDt52UiKd8`, outcome_root: `11111111111111111111111111111111`, encoded_merkle_root: `45Ze8dvm5A4zbY3Au5YBDowRCJv66KoGzc6d7Xuosg37`, encoded_length: 8, height_created: 42, shard_id: 1, gas_used: 0, gas_limit: 1000000, rent_paid: 0, validator_reward: 0, balance_burnt: 0, outgoing_receipts_root: `8s41rye686T2ronWmFE38ji19vgeb6uPxjYMPt8y8pSV`, tx_root: `11111111111111111111111111111111`, validator_proposals: [] }, height_included: 42, signature: ed25519:32ji64PEAU1vzw7rUeZejkxuk9SUyhzQL2P8F6qXfkracLDp2TXCGXXe51XYR1yCEEgBtaF3GAn1JGhgwSxT2BFG, hash: ChunkHash(`Gb4KE8yHCWHxRfidD4dTzEuet6kvvohBT78DqNXgsz9q`) }, ShardChunkHeader { inner: ShardChunkHeaderInner { prev_block_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, prev_state_root: `EgYyCMbQP5vfs65d8XLGoaWv3UGiVCEpvEvDt52UiKd8`, outcome_root: `11111111111111111111111111111111`, encoded_merkle_root: `45Ze8dvm5A4zbY3Au5YBDowRCJv66KoGzc6d7Xuosg37`, encoded_length: 8, height_created: 42, shard_id: 2, gas_used: 0, gas_limit: 1000000, rent_paid: 0, validator_reward: 0, balance_burnt: 0, outgoing_receipts_root: `8s41rye686T2ronWmFE38ji19vgeb6uPxjYMPt8y8pSV`, tx_root: `11111111111111111111111111111111`, validator_proposals: [] }, height_included: 42, signature: ed25519:25ftY2TjRqPzC8hWjidv5frY28fJYYmfSvWtBbTtoyPR8Dc6A74dngQA2rYAZuKofsv3x1NLZVp44LxXT3pTU7Br, hash: ChunkHash(`H3UiCFou41xMpfsrXQm5TXC2bSW6WZL8G3AWgCdcWuw7`) }, ShardChunkHeader { inner: ShardChunkHeaderInner { prev_block_hash: `HVZN24eDD6pxx5n3RGEwQyiBgETBjcyAyUMYg2DcirPW`, prev_state_root: `EgYyCMbQP5vfs65d8XLGoaWv3UGiVCEpvEvDt52UiKd8`, outcome_root: `11111111111111111111111111111111`, encoded_merkle_root: `45Ze8dvm5A4zbY3Au5YBDowRCJv66KoGzc6d7Xuosg37`, encoded_length: 8, height_created: 42, shard_id: 3, gas_used: 0, gas_limit: 1000000, rent_paid: 0, validator_reward: 0, balance_burnt: 0, outgoing_receipts_root: `8s41rye686T2ronWmFE38ji19vgeb6uPxjYMPt8y8pSV`, tx_root: `11111111111111111111111111111111`, validator_proposals: [] }, height_included: 42, signature: ed25519:4LMToUzGfxNwyci64PJQHzTZY4HxuFSvsJtVSj4AEANmZTxQsHm4Z2xvhfHxZUY8EDHQSXDdZcwn28GJnPZBSgJi, hash: ChunkHash(`AiaoXbUPhfWiDGyFS7deo8QMNDJMY6NAL3RTqcFun221`) }], challenges: [] }
thread 'tests::test_all_chunks_accepted_1000_slow' panicked at 'assertion failed: `(left == right)`
  left: `4`,
 right: `0`', chain/client/tests/catching_up.rs:685:29

codecov · 2020-01-15T00:40:50Z

Codecov Report

Merging #1956 into chunks_grieving will decrease coverage by 0.02%.
The diff coverage is 0%.

@@                 Coverage Diff                 @@
##           chunks_grieving    #1956      +/-   ##
===================================================
- Coverage            86.59%   86.57%   -0.03%     
===================================================
  Files                  167      167              
  Lines                31636    31491     -145     
===================================================
- Hits                 27395    27263     -132     
+ Misses                4241     4228      -13

Impacted Files	Coverage Δ
chain/client/tests/catching_up.rs	`9.67% <0%> (-1.92%)`	⬇️
chain/network/src/test_utils.rs	`93.1% <0%> (-2.3%)`	⬇️
chain/client/tests/cross_shard_tx.rs	`17.07% <0%> (-1.25%)`	⬇️
chain/chain/tests/sync_chain.rs	`84.61% <0%> (-1.1%)`	⬇️
core/primitives/src/serialize.rs	`82.19% <0%> (-0.93%)`	⬇️
chain/client/tests/query_client.rs	`87.5% <0%> (-0.74%)`	⬇️
...enesis-tools/genesis-csv-to-json/src/csv_parser.rs	`68.34% <0%> (-0.43%)`	⬇️
near/tests/sync_state_nodes.rs	`55.14% <0%> (-0.42%)`	⬇️
chain/jsonrpc/tests/http_query.rs	`93.75% <0%> (-0.37%)`	⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cddfcb4...101d617. Read the comment docs.

SkidanovAlex · 2020-01-15T17:35:19Z

chain/client/tests/catching_up.rs

@@ -640,4 +640,64 @@ mod tests {
        })
        .unwrap();
    }
+
+    #[test]
+    #[ignore]


Why ignore?

SkidanovAlex · 2020-01-15T17:35:40Z

nightly/nightly.txt

@@ -48,6 +48,9 @@ expensive near-client catching_up tests::test_catchup_random_single_part_sync_se
 expensive near-client catching_up tests::test_catchup_random_single_part_sync_non_zero_amounts
 expensive near-client catching_up tests::test_catchup_random_single_part_sync_height_6
 expensive near-client catching_up tests::test_catchup_sanity_blocks_produced
+expensive near-client catching_up tests::test_all_chunks_accepted_10


Not expensive, no need to include here?

Kouprin · 2020-01-16T17:45:03Z

added to #1945

tests_all_chunks_accepted

101d617

Kouprin requested review from bowenwang1996 and SkidanovAlex as code owners January 15, 2020 00:31

SkidanovAlex reviewed Jan 15, 2020

View reviewed changes

Kouprin changed the base branch from staging to chunks_grieving January 16, 2020 17:26

Kouprin closed this Jan 16, 2020

Kouprin deleted the tests_all_chunks_accepted branch January 16, 2020 22:47

weekly-digest bot mentioned this pull request Jan 17, 2020

Weekly Digest (10 January, 2020 - 17 January, 2020) #1976

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests_all_chunks_accepted #1956

tests_all_chunks_accepted #1956

Kouprin commented Jan 15, 2020 •

edited

Loading

codecov bot commented Jan 15, 2020 •

edited

Loading

SkidanovAlex Jan 15, 2020

SkidanovAlex Jan 15, 2020

Kouprin commented Jan 16, 2020

tests_all_chunks_accepted #1956

tests_all_chunks_accepted #1956

Conversation

Kouprin commented Jan 15, 2020 • edited Loading

codecov bot commented Jan 15, 2020 • edited Loading

Codecov Report

SkidanovAlex Jan 15, 2020

Choose a reason for hiding this comment

SkidanovAlex Jan 15, 2020

Choose a reason for hiding this comment

Kouprin commented Jan 16, 2020

Kouprin commented Jan 15, 2020 •

edited

Loading

codecov bot commented Jan 15, 2020 •

edited

Loading