Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty state response #1979

Merged
merged 5 commits into from
Jan 29, 2020
Merged

Empty state response #1979

merged 5 commits into from
Jan 29, 2020

Conversation

Kouprin
Copy link
Member

@Kouprin Kouprin commented Jan 18, 2020

Related to #1052.

@Kouprin Kouprin requested a review from SkidanovAlex January 18, 2020 11:48
@Kouprin Kouprin changed the base branch from T1971 to staging January 18, 2020 11:51
@Kouprin Kouprin force-pushed the empty_state_response branch from ffd2f2b to 3212fe4 Compare January 18, 2020 11:55
@Kouprin Kouprin changed the base branch from staging to T1971 January 18, 2020 11:55
@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #1979 into staging will decrease coverage by 0.33%.
The diff coverage is 77.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1979      +/-   ##
===========================================
- Coverage    87.37%   87.03%   -0.34%     
===========================================
  Files          167      170       +3     
  Lines        31851    33547    +1696     
===========================================
+ Hits         27830    29199    +1369     
- Misses        4021     4348     +327
Impacted Files Coverage Δ
runtime/near-vm-logic/src/gas_counter.rs 94.44% <ø> (ø) ⬆️
runtime/near-vm-runner/src/cache.rs 100% <ø> (ø) ⬆️
runtime/near-vm-runner/src/imports.rs 100% <ø> (ø) ⬆️
chain/client/src/lib.rs 0% <ø> (ø) ⬆️
chain/jsonrpc/client/src/lib.rs 83.58% <ø> (ø) ⬆️
runtime/near-vm-logic/src/types.rs 33.33% <ø> (ø) ⬆️
test-utils/testlib/src/user/mod.rs 58.24% <ø> (ø) ⬆️
chain/client/src/types.rs 77.77% <ø> (-1.91%) ⬇️
test-utils/testlib/src/node/mod.rs 100% <ø> (ø) ⬆️
near/tests/stake_nodes.rs 97.44% <ø> (ø) ⬆️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90fe43...0174915. Read the comment docs.

@Kouprin Kouprin force-pushed the empty_state_response branch 2 times, most recently from 001822f to 78ab6b6 Compare January 19, 2020 02:06
@Kouprin Kouprin force-pushed the T1971 branch 2 times, most recently from 3a5361d to 6ff6506 Compare January 21, 2020 11:28
@Kouprin Kouprin changed the base branch from T1971 to staging January 21, 2020 11:46
@Kouprin Kouprin force-pushed the empty_state_response branch from 3e40f17 to 8385648 Compare January 25, 2020 09:15
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason for splitting state request into StateRequestHeader and StateRequestPart?

chain/chain/src/chain.rs Outdated Show resolved Hide resolved
@Kouprin
Copy link
Member Author

Kouprin commented Jan 28, 2020

what's the reason for splitting state request into StateRequestHeader and StateRequestPart?

Code quality. We're having less magic inside.
Technically, those requests are different. One of them is about getting State Header, and the other one is for getting State Part. That's why I decided to make things clearer by splitting original StateRequest.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit ea8dc46 into staging Jan 29, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the empty_state_response branch January 29, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants