Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #2037

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Remove warnings #2037

merged 2 commits into from
Jan 31, 2020

Conversation

mfornet
Copy link
Member

@mfornet mfornet commented Jan 29, 2020

No description provided.

Copy link
Member

@Kouprin Kouprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #2037 into staging will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2037      +/-   ##
===========================================
- Coverage    87.31%   87.19%   -0.13%     
===========================================
  Files          170      169       -1     
  Lines        33918    33805     -113     
===========================================
- Hits         29616    29476     -140     
- Misses        4302     4329      +27
Impacted Files Coverage Δ
chain/client/src/test_utils.rs 76.6% <0%> (-10%) ⬇️
chain/network/tests/churn_attack.rs 89.47% <0%> (-5.27%) ⬇️
chain/chain/src/test_utils.rs 85.16% <0%> (-4.03%) ⬇️
chain/client/tests/cross_shard_tx.rs 18.37% <0%> (-1.45%) ⬇️
chain/client/tests/query_client.rs 87.5% <0%> (-0.74%) ⬇️
chain/network/tests/routing.rs 99.04% <0%> (-0.49%) ⬇️
chain/chain/src/validate.rs 91.1% <0%> (-0.36%) ⬇️
chain/client/src/client_actor.rs 86.53% <0%> (-0.33%) ⬇️
chain/chunks/src/lib.rs 93.29% <0%> (-0.31%) ⬇️
chain/client/src/sync.rs 88.14% <0%> (-0.16%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9ebd7...d54d757. Read the comment docs.

Copy link
Collaborator

@SkidanovAlex SkidanovAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one non-expensive test in this file, so just hide the entire mod test behind expensive features (the one test that is not expensive is OK to be removed from the CI, the basic tests in chunks_management that cover most of what it covers)

@SkidanovAlex SkidanovAlex merged commit d07db7d into staging Jan 31, 2020
@SkidanovAlex SkidanovAlex deleted the remove_warning branch January 31, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants