-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warnings #2037
Remove warnings #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
Codecov Report
@@ Coverage Diff @@
## staging #2037 +/- ##
===========================================
- Coverage 87.31% 87.19% -0.13%
===========================================
Files 170 169 -1
Lines 33918 33805 -113
===========================================
- Hits 29616 29476 -140
- Misses 4302 4329 +27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's only one non-expensive test in this file, so just hide the entire mod test
behind expensive features
(the one test that is not expensive is OK to be removed from the CI, the basic tests in chunks_management
that cover most of what it covers)
49a931a
to
d54d757
Compare
No description provided.