Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort near-crypto dependencies and remove unused dependency on criterion. #2101

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

abacabadabacaba
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which tool did you use to sort this?

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #2101 into staging will decrease coverage by 0.22%.
The diff coverage is 89.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2101      +/-   ##
===========================================
- Coverage    86.97%   86.75%   -0.23%     
===========================================
  Files          173      178       +5     
  Lines        33974    34040      +66     
===========================================
- Hits         29549    29530      -19     
- Misses        4425     4510      +85
Impacted Files Coverage Δ
chain/network/tests/runner/mod.rs 96.14% <ø> (ø) ⬆️
core/primitives/src/lib.rs 100% <ø> (ø) ⬆️
near/src/runtime.rs 70.35% <ø> (-0.44%) ⬇️
chain/jsonrpc/src/lib.rs 69.59% <ø> (ø) ⬆️
core/primitives/src/utils.rs 91.02% <ø> (ø) ⬆️
near/tests/sync_state_nodes.rs 55.14% <ø> (ø) ⬆️
chain/client/src/info.rs 69.74% <ø> (ø) ⬆️
chain/client/src/types.rs 63.93% <ø> (-21.19%) ⬇️
runtime/runtime/src/metrics.rs 90.9% <ø> (ø) ⬆️
runtime/runtime/tests/runtime_group_tools/mod.rs 98.29% <ø> (ø) ⬆️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a994690...8969e49. Read the comment docs.

@abacabadabacaba
Copy link
Collaborator Author

@bowenwang1996 Text editor.

@abacabadabacaba abacabadabacaba merged commit 5faf22a into staging Feb 14, 2020
@abacabadabacaba abacabadabacaba deleted the sort-crypto-dependencies branch February 14, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants