Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VRF function names: check -> is_valid, check_vrf -> is_vrf_valid. #2106

Merged
merged 4 commits into from
Feb 15, 2020

Conversation

abacabadabacaba
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #2106 into staging will decrease coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2106      +/-   ##
===========================================
- Coverage    86.78%   86.77%   -0.02%     
===========================================
  Files          178      179       +1     
  Lines        34034    34190     +156     
===========================================
+ Hits         29536    29667     +131     
- Misses        4498     4523      +25
Impacted Files Coverage Δ
core/crypto/src/vrf.rs 98.07% <100%> (+0.03%) ⬆️
core/crypto/src/key_conversion.rs 86.95% <86.95%> (ø)
chain/network/tests/churn_attack.rs 89.47% <0%> (-5.27%) ⬇️
chain/client/src/types.rs 59.01% <0%> (-1.64%) ⬇️
chain/client/src/sync.rs 84.56% <0%> (-1.47%) ⬇️
chain/client/src/client.rs 93.43% <0%> (-1.29%) ⬇️
chain/network/src/test_utils.rs 91.48% <0%> (-1.07%) ⬇️
chain/network/src/peer.rs 74% <0%> (-0.6%) ⬇️
chain/chain/src/test_utils.rs 85.09% <0%> (-0.19%) ⬇️
chain/client/src/client_actor.rs 83.44% <0%> (-0.17%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837bdec...1a7e112. Read the comment docs.

@abacabadabacaba abacabadabacaba merged commit ba0b243 into staging Feb 15, 2020
@abacabadabacaba abacabadabacaba deleted the crypto-vrf-better-names branch February 15, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants