feat: added husky precommit hook #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugosenari please review my PR. |
hugosenari
reviewed
Feb 13, 2022
hugosenari
reviewed
Feb 13, 2022
hugosenari
reviewed
Feb 14, 2022
hugosenari
reviewed
Feb 16, 2022
|
shameless, copied from the link of your comments |
hugosenari
approved these changes
Feb 16, 2022
ceilfors
reviewed
Feb 18, 2022
ceilfors
reviewed
Feb 19, 2022
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| npx --no-install commitlint --edit |
There was a problem hiding this comment.
Can we make it consistent on where husky is configured? Your change make commitlint running as sh, but the sh for pre-commit is now empty and moved to package.json. What's the rationale?
There was a problem hiding this comment.
I have used this article for implementation with minor modifications.
|
@Samridhi-98 Thanks for your contribution so far! I feel like this is an unsuitable ticket for the first ticket in this repo as I have many questions before this PR can be merged (one example is the husky version downgrade). I worry that it'll create a lot more work for you in the end. Thanks a lot for your attempt 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
package.jsonIssue
Fixes #545