Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neb API arguments check #16

Open
qywang2012 opened this issue Apr 4, 2018 · 3 comments
Open

Neb API arguments check #16

qywang2012 opened this issue Apr 4, 2018 · 3 comments
Assignees
@qywang2012
Labels
enhancement New feature or request

Comments

@qywang2012
Copy link
Contributor

Nebulas currently have a usable js version to create the wallet address and send the transaction. Neb. js implements all the RPC interfaces of the Nebulas, but none of these interfaces currently add parameter validation.

We should add parameter validation to these interfaces and functions.

RPC interfaces:

Functions

  • Transaction: The parameters of the constructor need to be checked.
    • chainID should be valid(1 Mainnet, 100[1/2/...] Testnet)
    • from must be a valid address with a private key
    • nonce must be a number
@qywang2012 qywang2012 added the enhancement New feature or request label Apr 4, 2018
@qywang2012 qywang2012 self-assigned this Apr 4, 2018
@qywang2012
Copy link
Contributor Author

Can some guys give help for the parameter check?

@ChengOrangeJu
Copy link
Contributor

Issue status update: Help is still needed from community :)

@catalsdevelop
Copy link

can we improve this with a typescript definition file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qywang2012 qywang2012

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qywang2012 @catalsdevelop @ChengOrangeJu