fix(deps): bump find-my-way from 8.2.0 to 8.2.2 and vite from 5.2.10 to 5.4.6 #6828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const DENO_VERSION_RANGE = '1.37.0 - 1.44.4' Latest is 1.46.3 now, so CLI tries to download one instead of using one we install ourselves in GHA and that is very flaky in Windows tests
Bumps [find-my-way](https://github.com/delvedor/find-my-way) from 8.2.0 to 8.2.2. - [Release notes](https://github.com/delvedor/find-my-way/releases) - [Commits](delvedor/find-my-way@v8.2.0...v8.2.2) --- updated-dependencies: - dependency-name: find-my-way dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.10 to 5.4.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
pieh
commented
Sep 19, 2024
| @@ -62,7 +62,7 @@ jobs: | |||
| uses: denoland/setup-deno@v1 | |||
| if: '${{!steps.release-check.outputs.IS_RELEASE}}' | |||
| with: | |||
| deno-version: v1.x | |||
| deno-version: v1.44.4 | |||
There was a problem hiding this comment.
Our supported deno version range is:
const DENO_VERSION_RANGE = '1.37.0 - 1.44.4'
Latest is 1.46.3 now, so CLI tries to download one instead of using one we install ourselves in GHA and that is very flaky in Windows tests, so instead let's install Deno version that matches supported range in first place
pieh
commented
Sep 19, 2024
| test<FixtureTestContext>( | ||
| 'should run deploy with --build without any netlify specific configuration', | ||
| { | ||
| timeout: 300_000, |
There was a problem hiding this comment.
This seems to often timeout in windows tests, so just increasing timeout here
pieh
changed the title
serhalp
changed the title
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Contains #6824 + #6822 + some test adjustments to decrease some flakiness
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)