Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom webpack config #6

Closed
kantle opened this issue Jan 14, 2018 · 1 comment
Closed

Custom webpack config #6

kantle opened this issue Jan 14, 2018 · 1 comment

Comments

@kantle
Copy link

kantle commented Jan 14, 2018

Thanks for adding support for this in Version 0.2.0.

I believe this was only added for the build, not serve command. If you look at line 63 of build.js you see that additionalConfig is passed to webpackConfig, however in lines 73 and 74 additionalConfig is not passed. The result is that custom webpack configs are incorporated when running build -c, but not when running serve -c.
@verythorough verythorough mentioned this issue Mar 24, 2018
Merged
@verythorough
Copy link
Contributor

Closed by #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kantle @verythorough