New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded string to constant from sdk-sriov #22

Open

denis-tingaikin opened this issue Sep 23, 2021 · 0 comments

Assignees

Labels

Member

denis-tingaikin commented Sep 23, 2021 •

edited

Loading

Context

Motivation

Hardcoded strings can be replaced to const from sdk-sriov
https://github.com/networkservicemesh/cmd-admission-webhook-k8s/blob/main/main.go#L186-L187

Implementation details

Export constant from sdk-sriov by separate PR.
Replace hardcoded strings to the constant.

denis-tingaikin assigned mardim91

denis-tingaikin added the enhancement label

denis-tingaikin added this to Release 1.2.0

edwarnicke removed this from Release 1.2.0

edwarnicke added this to Release 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment