Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App doesn't unregister webhook on exit #281

Open
d-uzlov opened this issue May 10, 2023 · 0 comments
Open

App doesn't unregister webhook on exit #281

d-uzlov opened this issue May 10, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@d-uzlov
Copy link

d-uzlov commented May 10, 2023

Steps to reproduce:

  1. Apply basic NSM setup: https://github.com/networkservicemesh/deployments-k8s/tree/main/examples/basic
  2. Make sure webhook started and self-registered: check k1 get mutatingwebhookconfigurations.admissionregistration.k8s.io
  3. Delete NSM from cluster
  4. Check k1 get mutatingwebhookconfigurations.admissionregistration.k8s.io again

Expected result:

List doesn't contain admission-webhook-* instance

Actual result:

Mutating webhook list still contains NSM webhook.

Additional info:

It seems like webhook tries to unregister the entry but it doesn't happen for some reason:

_ = registerClient.Unregister(context.Background(), conf)

Also, in the deployments repo in the cleanup section we delete the webhook manually, so it must be a known behavior? But surely this must be just a half-documented bug.
https://github.com/networkservicemesh/deployments-k8s/tree/d43747cbd24515b152ef11aec6bc4f61ea2bdc88/examples/basic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants