Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NewClient instead of NewServerToClient #1147

Closed
glazychev-art opened this issue Nov 10, 2021 · 1 comment · Fixed by #1186
Closed

Use NewClient instead of NewServerToClient #1147

glazychev-art opened this issue Nov 10, 2021 · 1 comment · Fixed by #1186
Assignees
@Mixaster995

Comments

@glazychev-art
Copy link
Contributor

Description

We need to create setlogoption.NewClient and replace adapters.NewServerToClient usage.
https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/client/client.go#L55
@Mixaster995 Mixaster995 self-assigned this Nov 10, 2021
@Mixaster995 Mixaster995 mentioned this issue Nov 10, 2021
Closed
5 tasks
@edwarnicke
Copy link
Member

@glazychev-art Can this be closed now?

@Mixaster995 Mixaster995 mentioned this issue Dec 2, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mixaster995 Mixaster995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed usage of setlogoption chain element Mixaster995/sdk
Removed adapters Mixaster995/sdk
3 participants
@edwarnicke @glazychev-art @Mixaster995