Use coding-conventions helpers; accelerate build with ninja. #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least some of the failures are related to BlueBrain/hpc-coding-conventions#100. |
olupton
force-pushed
the
olupton/cmake-improvements
branch
2 times, most recently
from
5f138a8 to
e78fb7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
+ Coverage 31.39% 31.47% +0.07%
==========================================
Files 571 571
Lines 108818 108818
==========================================
+ Hits 34160 34246 +86
+ Misses 74658 74572 -86
Continue to review full report at Codecov.
|
olupton
force-pushed
the
olupton/cmake-improvements
branch
from
e78fb7e to
1c3bad9
Compare
pramodk
approved these changes
Apr 13, 2021
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 13, 2021
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coding-conventionssubmodule if it's missing, not just whenNEURON_CMAKE_FORMATis set.cpp_cc_build_time_copyutility fromcoding-conventionsinstead of custom commands usingcmake -E copy_if_different, this is more expressive and allows the build system (Ninja, make etc.) to check for updates more efficiently ( + makes it easier to declare dependencies on the build-tree copies of files).${PROJECT_SOURCE_DIR}/share/libto${PROJECT_BINARY_DIR}/share/nrn/libtwice.In my setup (
cmake -G Ninja ...) this makes the initial run of CMake a little faster and makes incremental builds with few changes O(10x) faster (cmake --build .with no changes now takes ~1s not ~10s). It also removes some spammy output from the test infrastructure towards the end of CMake execution. When using legacy Unix Makefiles/makethe improvement is smaller but still extant.(see also BlueBrain/CoreNeuron#517 which is along the same lines)