-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] ecg_process: improve documentation and readability #871
[Docs] ecg_process: improve documentation and readability #871
Conversation
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
Hi @jchromik sorry I completely missed that, we'll review shortly :) thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @jchromik ! I left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @jchromik ! @DominiqueMakowski feel free to merge
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #871 +/- ##
==========================================
+ Coverage 55.23% 55.24% +0.01%
==========================================
Files 297 297
Lines 13917 13916 -1
==========================================
+ Hits 7687 7688 +1
+ Misses 6230 6228 -2
☔ View full report in Codecov by Sentry. |
Description
This PR aims at updating and improving the documentation and code readability of the ecg_process() function.
Proposed Changes
This PR does not change any external behaviour of the function. Just refactoring and documentation.
Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)