Add dark mode toggle in documentation. #1178
Closed
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TG1999 can merge this PR instead . |
AyanSinhaMahapatra
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
LGTM! Thanks! I think we should also add the same to https://github.com/nexB/skeleton, to have this everywhere.
|
|
||
| # user starts in light mode | ||
|
|
||
| default_dark_mode = False |
There was a problem hiding this comment.
Yes, this is what we want, light stays as default, as that is the case without this plugin.
There was a problem hiding this comment.
Yes, this is what we want, light stays as default, as that is the case without this plugin.
Yep ✨
|
Will add this in the skeleton as soon as possible ✨🚀 |
Signed-off-by: swastik <[email protected]>
TG1999
force-pushed
the
dark-mode-documentation
branch
from
2e470f8 to
d98aac9
Compare
|
@swastkk I am closing this PR in favour of aboutcode-org/skeleton@5ab9b3a, thanks again for raising this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference- #1177
Signed-off-by - swastik [email protected]