Replace tune icon with filter icon

[Jerome-Herbinet]

Fixes: #9942

Check commit.

I don't have a test environment. Test from reviewers need.

[ChristophWurst]

The icon component is not registered on the Vue component

[Jerome-Herbinet]

The icon component is not registered on the Vue component

@ChristophWurst this is new for me ; how to do that ? Can you help me ?

[ChristophWurst]

Delete

mail/src/components/SearchMessages.vue

Line 299 in 295a1dc

import Tune from 'vue-material-design-icons/Tune.vue'

and replace Tune with FilterIcon at

mail/src/components/SearchMessages.vue

Line 321 in 295a1dc

Tune,

[jancborchardt]

@ChristophWurst @Jerome-Herbinet I think it will have to be FilterVariantIcon so it is going to be the list/filter icon (not the funnel) as per https://fonts.google.com/icons?icon.set=Material+Symbols&icon.size=24&icon.color=%235f6368&selected=Material+Symbols+Outlined:filter_list:FILL@1;wght@400;GRAD@0;opsz@24&icon.query=filter ?

[Jerome-Herbinet]

Delete

mail/src/components/SearchMessages.vue

Line 299 in 295a1dc

import Tune from 'vue-material-design-icons/Tune.vue'

and replace Tune with FilterIcon at

mail/src/components/SearchMessages.vue

Line 321 in 295a1dc

Tune,

@ChristophWurst OK

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[ChristophWurst]

Looks good!

Did not test

[Jerome-Herbinet]

@jancborchardt could you test it ?

[jancborchardt]

@Jerome-Herbinet as per my comment before, the icon probably needs to be "FilterVariant".

It should not look like this funnel icon, but rather like this list filter icon.

[Jerome-Herbinet]

@Jerome-Herbinet as per my comment before, the icon probably needs to be "FilterVariant".

It should not look like this funnel icon, but rather like this list filter icon.

OK @jancborchardt ; to make finding icons easier, can you tell me how (and/ore where) you easily browse your entire Nextcloud icon collection to select the right one (AFAIK I can't open files viewed as an image...).

[jancborchardt]

@Jerome-Herbinet as far as I know, that is https://pictogrammers.com/library/mdi/ – but a frontender would have to help here.

[st3iny]

Works so far. Just needs the correct icon, as Jan mentioned.

[ChristophWurst]

What was force pushed? The icon is still to be replaced, right?

[Jerome-Herbinet]

What was force pushed? The icon is still to be replaced, right?

Yes, forget it, I still have to make discussed changes.

[Jerome-Herbinet]

Please check and test my last commit @jancborchardt @st3iny

[jancborchardt]

Seems good – don’t know about the icon naming conventions but it seems the variables usually don’t have "Icon" appended, so you could call it simply "FilterVariant" instead of "FilterVariantIcon"?

[st3iny]

Tested and works. Thank you very much :)