-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recipient info on the right side of the composer #9824
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The raw search query that works <?xml version="1.0"?>
<x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
<x0:prop xmlns:x0="DAV:">
<x0:getcontenttype/>
<x0:getetag/>
<x0:resourcetype/>
<x0:displayname/>
<x0:owner/>
<x0:resourcetype/>
<x0:sync-token/>
<x0:current-user-privilege-set/>
<x0:getcontenttype/>
<x0:getetag/>
<x0:resourcetype/>
<x4:address-data/>
</x0:prop>
<x4:filter test="allof">
<x4:prop-filter name="EMAIL">
<x1:text-match xmlns:x1="urn:ietf:params:xml:ns:carddav">[email protected]</x1:text-match>
</x4:prop-filter>
</x4:filter>
</x4:addressbook-query> |
41e2077
to
8673d84
Compare
9d09ecc
to
515402f
Compare
This change needs a counterpart in Contacts. Where can we find that change? |
the description was not updated recently, sorry about that, i added the info of the current state. |
thanks so much for reviewing. i will wait for a second reviewer and deliver all in one fixup, <3 |
12edd52
to
a987229
Compare
|
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its there, if you click the minimaze/maximize button on top right :) you can remove it and continue with your composer only view |
04eacbd
to
cf26a21
Compare
Signed-off-by: greta <[email protected]>
cf26a21
to
4e539a2
Compare
Ah. Okay, That might be a bit confusing. I thought that was to minimize the entire modal. Would be better to put a > icon in the top left corner of the pane. But that is up to design. |
fixes #9622
requires: nextcloud/contacts#4194
to do
PR description:
When a user is added to the "To" field in the mail composer, a right pane displays the contact details from their profile. Adding a second recipient collapses the list of contact details, with an option to toggle the visibility of the pane to view the data. Clicking the "maximize" button removes the right pane entirely to focus on the composer. Reducing the composer size restores the right pane, making the contact details visible again.
Single recipient
2 recipients collapsed view
2 reicpients, 1 expanded