Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recipient info on the right side of the composer #9824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jul 10, 2024

fixes #9622
requires: nextcloud/contacts#4194
to do

  • change the classes to BEM styling.

PR description:
When a user is added to the "To" field in the mail composer, a right pane displays the contact details from their profile. Adding a second recipient collapses the list of contact details, with an option to toggle the visibility of the pane to view the data. Clicking the "maximize" button removes the right pane entirely to focus on the composer. Reducing the composer size restores the right pane, making the contact details visible again.

Single recipient
Screenshot from 2024-11-26 12-33-46
2 recipients collapsed view
Screenshot from 2024-11-26 12-33-56
2 reicpients, 1 expanded
Screenshot from 2024-11-26 12-34-10

@GretaD

This comment was marked as outdated.

@ShGKme

This comment was marked as outdated.

@ChristophWurst
Copy link
Member

The raw search query that works

<?xml version="1.0"?>
<x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
  <x0:prop xmlns:x0="DAV:">
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x0:displayname/>
    <x0:owner/>
    <x0:resourcetype/>
    <x0:sync-token/>
    <x0:current-user-privilege-set/>
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x4:address-data/>
  </x0:prop>
  <x4:filter test="allof">
    <x4:prop-filter name="EMAIL">
      <x1:text-match xmlns:x1="urn:ietf:params:xml:ns:carddav">[email protected]</x1:text-match>
    </x4:prop-filter>
  </x4:filter>
</x4:addressbook-query>

@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 41e2077 to 8673d84 Compare August 21, 2024 13:51
@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 9d09ecc to 515402f Compare September 10, 2024 12:41
@ChristophWurst
Copy link
Member

This change needs a counterpart in Contacts. Where can we find that change?

@GretaD
Copy link
Contributor Author

GretaD commented Nov 18, 2024

This change needs a counterpart in Contacts. Where can we find that change?

the description was not updated recently, sorry about that, i added the info of the current state.

GVodyanov

This comment was marked as resolved.

@GretaD
Copy link
Contributor Author

GretaD commented Nov 25, 2024

I only see the email address in the right pane when having two recipients, no error in console

thanks so much for reviewing. i will wait for a second reviewer and deliver all in one fixup, <3

@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 12edd52 to a987229 Compare November 25, 2024 11:39
@GretaD GretaD requested a review from GVodyanov November 26, 2024 11:40
@kesselb
Copy link
Contributor

kesselb commented Dec 3, 2024

  • I'm not a fan of showing the sidebar when entering an email address / selecting a contact because it shifts the composer modal. What do you think about always showing the sidebar?
  • It's possible to select a contact group as recipient. This will also trigger the xhr request to find the contact details. Could we add a check if recipient starts with "nextcloud:" then don't search the contact details? A possible enhancement for a follow-up could be to list the members of the group.

@kesselb

This comment was marked as resolved.

src/store/getters.js Outdated Show resolved Hide resolved
@GVodyanov GVodyanov self-requested a review December 9, 2024 18:44
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works.

The only thing I would add is the ability to minimize the side pane. It takes up a lot of room and makes the email message area very small.

image

@GretaD
Copy link
Contributor Author

GretaD commented Dec 10, 2024

Tested. Works.

The only thing I would add is the ability to minimize the side pane. It takes up a lot of room and makes the email message area very small.

its there, if you click the minimaze/maximize button on top right :) you can remove it and continue with your composer only view

@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 04eacbd to cf26a21 Compare December 10, 2024 17:23
@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from cf26a21 to 4e539a2 Compare December 10, 2024 17:27
@SebastianKrupinski
Copy link
Contributor

its there, if you click the minimaze/maximize button on top right :) you can remove it and continue with your composer only view

Ah. Okay, That might be a bit confusing. I thought that was to minimize the entire modal. Would be better to put a > icon in the top left corner of the pane. But that is up to design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient info next to mail composer
6 participants