Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SpeakingWhileMutedWarner): show warning in the popup #14152

Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix(SpeakingWhileMutedWarner): show warning in the popup #14152

merged 3 commits into from
Jan 29, 2025
+129 −72

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 17, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

TODO

  • add timeout to fade notification/popup (if microphone noise is static)
  • move visual logic to LocalAudio*
  • Check for obstructions (to not show popover above other elements)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 🌿 Next Beta (31) milestone Jan 17, 2025
@Antreesy Antreesy requested a review from DorraJaouad January 17, 2025 15:49
@Antreesy Antreesy self-assigned this Jan 17, 2025
@Antreesy
Copy link
Contributor Author

backport to stable30

DorraJaouad
DorraJaouad reviewed Jan 20, 2025
View reviewed changes
src/utils/webrtc/SpeakingWhileMutedWarner.js Outdated Show resolved Hide resolved
src/utils/webrtc/SpeakingWhileMutedWarner.js Outdated Show resolved Hide resolved
src/components/TopBar/TopBarMediaControls.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/14029/muted-speaker branch from 4df3560 to bdaa367 Compare January 20, 2025 14:48
@nickvergessen
Copy link
Member

/backport to stable31

@Antreesy
fix(SpeakingWhileMutedWarner): add timeout to hide message in case of…
879ace4 
… constant noise (7 seconds)

- also hide message on destroy

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(SpeakingWhileMutedWarner): replace toast message with popup
d7fe641 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/14029/muted-speaker branch from bdaa367 to c31f6c6 Compare January 27, 2025 16:39
DorraJaouad
DorraJaouad approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy
fix(LocalAudioControlButton): show popup when microphone is muted
aadd013 
- detach logic from TopBar

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/14029/muted-speaker branch from c31f6c6 to aadd013 Compare January 29, 2025 09:47
@Antreesy
Copy link
Contributor Author

removed { deep: true } form watcher

@Antreesy Antreesy merged commit 00e504a into main Jan 29, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/14029/muted-speaker branch January 29, 2025 11:02
@backportbot backportbot bot mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.

Make 'speak while muted' a tooltip again
4 participants
@Antreesy @nickvergessen @ShGKme @DorraJaouad