Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tried to call participant" shown instead of end call - race condition? #14123

Open
SystemKeeper opened this issue Jan 13, 2025 · 0 comments
Open
Assignees
Labels
0. Needs triage bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls

Comments

@SystemKeeper
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Have a call
  2. Part A leaves call shortly before Part B

Expected behaviour

call_ended system message should be generated

Actual behaviour

call_tried system messages is generated

Image Image

Possible race somewhere at

$duration = $this->timeFactory->getTime() - $activeSince->getTimestamp();
$userIds = $this->participantService->getParticipantUserIds($room, $activeSince);
$cloudIds = $this->participantService->getParticipantActorIdsByActorType($room, [Attendee::ACTOR_FEDERATED_USERS], $activeSince);
$numGuests = $this->participantService->getActorsCountByType($room, Attendee::ACTOR_GUESTS, $activeSince->getTimestamp());
$numGuests += $this->participantService->getActorsCountByType($room, Attendee::ACTOR_EMAILS, $activeSince->getTimestamp());
$message = 'call_ended';
if ($event instanceof CallEndedForEveryoneEvent) {
$message = 'call_ended_everyone';
} elseif (($room->getType() === Room::TYPE_ONE_TO_ONE || $room->getType() === Room::TYPE_ONE_TO_ONE_FORMER) && \count($userIds) === 1) {
$message = 'call_missed';
}

?

Talk app

Talk app version: 20.1.1

@SystemKeeper SystemKeeper added 0. Needs triage bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls labels Jan 13, 2025
@miaulalala miaulalala self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls
Projects
None yet
Development

No branches or pull requests

2 participants