Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce /read requests during call #14177

Open
SystemKeeper opened this issue Jan 23, 2025 · 0 comments
Open

Reduce /read requests during call #14177

SystemKeeper opened this issue Jan 23, 2025 · 0 comments

Comments

@SystemKeeper
Copy link
Contributor

SystemKeeper commented Jan 23, 2025

The Web utilizes the dedicated /read endpoint to mark the chat as read (https://github.com/nextcloud/spreed/blob/main/docs/chat.md#mark-chat-as-read). To reduce the number of queries to the server during a call, the idea is to not use the dedicated read marker endpoint, but set the setReadMarker parameter on the long polling request instead: https://github.com/nextcloud/spreed/blob/main/docs/chat.md#chat-api

Question raised by @nickvergessen: Would that interfere with the "You have unread messages in the chat" message, when the chat is hidden in a call?

if ($lookIntoFuture && $setReadMarker === 1 &&
$lastKnownMessageId > $attendee->getLastReadMessage()) {
$this->participantService->updateLastReadMessage($this->participant, $lastKnownMessageId);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

No branches or pull requests

2 participants