Adding a group to a Team doesn't trigger chat notifications for added members

[miaulalala]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Add a Team to a chat
2. Later, add a group to the Team

Expected behaviour

As with sub- Teams, the group add creates chat messages for the added user.
Example - adding a sub Team to a Team that is already a member of the chat:

Actual behaviour

No chat notifications are generated and the users are added silently.

Talk app

Talk app version: 21.0.0-beta2

Custom Signaling server configured: yes/no and version (see Talk administration settings: /index.php/settings/admin/talk#signaling_server) yes

Custom TURN server configured: yes/no (see Talk administration settings: /index.php/settings/admin/talk#turn_server)

Custom STUN server configured: yes/no (see Talk administration settings: /index.php/settings/admin/talk#stun_server)

Browser

Microphone available: yes

Camera available: yes

Operating system: Ubuntu

Browser name: Firefox

Browser version: 133

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

Server configuration

Operating system: Ubuntu

Web server: Apache

Database: Maria

PHP version: 8.3

Nextcloud Version: Hub10/31 beta4

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Server log (data/nextcloud.log)

Insert your server log here

[nickvergessen]

That should not trigger a chat notification but an invite one

Normal code is in

spreed/lib/Notification/Listener.php

Lines 75 to 126 in ece1dec

	protected function generateInvitation(Room $room, array $attendees): void {
	if ($room->getObjectType() === Room::OBJECT_TYPE_FILE) {
	return;
	}
	$actor = $this->userSession->getUser();
	if (!$actor instanceof IUser) {
	return;
	}
	$actorId = $actor->getUID();
	$notification = $this->notificationManager->createNotification();
	$shouldFlush = $this->notificationManager->defer();
	$dateTime = $this->timeFactory->getDateTime();
	try {
	$notification->setApp(Application::APP_ID)
	->setDateTime($dateTime)
	->setObject('room', $room->getToken())
	->setSubject('invitation', [
	'actorId' => $actor->getUID(),
	]);
	} catch (\InvalidArgumentException $e) {
	$this->logger->error($e->getMessage(), ['exception' => $e]);
	if ($shouldFlush) {
	$this->notificationManager->flush();
	}
	return;
	}
	foreach ($attendees as $attendee) {
	if ($attendee->getActorType() !== Attendee::ACTOR_USERS) {
	// No user => no activity
	continue;
	}
	if ($actorId === $attendee->getActorId()) {
	// No activity for self-joining and the creator
	continue;
	}
	try {
	$notification->setUser($attendee->getActorId());
	$this->notificationManager->notify($notification);
	} catch (\InvalidArgumentException $e) {
	$this->logger->error($e->getMessage(), ['exception' => $e]);
	}
	}
	if ($shouldFlush) {
	$this->notificationManager->flush();
	}
	}

but currently any non-user things from teams are ignored:

spreed/lib/Listener/CircleMembershipListener.php

Lines 114 to 117 in c66439d

	if ($member->getUserType() !== Member::TYPE_USER || $member->getUserId() === '') {
	// Not a user?
	return;
	}