Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Preview of readme broken when folder is opened via favourites #3697

Closed
6 of 9 tasks
kaystrobach opened this issue Jan 25, 2023 · 6 comments
Closed
6 of 9 tasks
Labels
0. Needs triage bug Something isn't working

Comments

@kaystrobach
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Hello,

when you use the files app, you normally get the preview of an readme file.
This is not the case, when you use the favourites in nextcloud

Steps to reproduce

This works using the following steps:

  1. open files app click a folder
  2. see preview
  3. click it
  4. edit it

grafik

Using the favourites this breaks:

  1. open the files app
  2. click favourites in the left bar
  3. click a folder, which is in the favourites
  4. now the readme is only in the file list, but not in the preview area above the file list

grafik

URLs:

Preview broken:

https://<host>/index.php/apps/files/?dir=/Haus/WEG/2023-01-25&fileid=580961

Works:

https://<host>/index.php/apps/files/?dir=/Haus/WEG/2023-01-25&fileid=580961

Seem to be the very same views, but anyway they behave differently

Side note clicking the house (root folder) symbol from a favourite view, also breaks the view for subsequent views, so that the preview is missing.
I need to reclick the files app icon to get the preview working again.

Expected behavior

Preview regardless of way of access to the folder.

Installation method

Other Community project

Operating system

Debian/Ubuntu

PHP engine version

PHP 7.4

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***"
        ],
        "filelocking.enabled": true,
        "memcache.locking": "\\OC\\Memcache\\APCu",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "25.0.2.3",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 4,
        "theme": "",
        "maintenance": false,
        "forcessl": true,
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trashbin_retention_obligation": "auto",
        "appcodechecker": true,
        "updatechecker": true,
        "has_internet_connection": true,
        "check_for_working_webdav": true,
        "check_for_working_htaccess": true,
        "config_is_read_only": false,
        "enable_previews": true,
        "mail_smtpauth": 1,
        "mail_smtpauthtype": "LOGIN",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpsecure": "ssl",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "stable",
        "mysql.utf8mb4": true,
        "default_phone_region": "DE",
        "app_install_overwrite": [
            "bruteforcesettings",
            "appointments",
            "sentry",
            "bookmarks",
            "impersonate",
            "talk_matterbridge"
        ]
    }
}

List of activated Apps

Enabled:
  - activity: 2.17.0
  - admin_audit: 1.15.0
  - bookmarks: 12.0.0
  - bruteforcesettings: 2.5.0
  - calendar: 4.2.1
  - circles: 25.0.0
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contacts: 5.0.3
  - contactsinteraction: 1.6.0
  - dashboard: 7.5.0
  - dav: 1.24.0
  - deck: 1.8.3
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.1
  - files_external: 1.17.0
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - fileslibreofficeedit: 1.1.0
  - firstrunwizard: 2.14.0
  - impersonate: 1.11.0
  - integration_gitlab: 1.0.12
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - mail: 2.2.2
  - maps: 0.2.4
  - nextcloud_announcements: 1.14.0
  - notes: 4.6.0
  - notifications: 2.13.1
  - oauth2: 1.13.0
  - password_policy: 1.15.0
  - photos: 2.0.1
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - quota_warning: 1.15.0
  - ransomware_protection: 1.14.0
  - recommendations: 1.4.0
  - related_resources: 1.0.4
  - richdocuments: 7.1.0
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - spreed: 15.0.3
  - support: 1.8.0
  - survey_client: 1.13.0
  - systemtags: 1.15.0
  - talk_matterbridge: 1.25.2
  - tasks: 0.14.5
  - text: 3.6.0
  - theming: 2.0.1
  - twofactor_backupcodes: 1.14.0
  - twofactor_totp: 7.0.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
Disabled:
  - appointments: 1.14.10
  - encryption: 2.6.0
  - files_downloadactivity: 1.15.0
  - richdocumentscode: 22.5.802
  - sentry: 8.3.4
  - suspicious_login
  - user_ldap

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

@kaystrobach kaystrobach added 0. Needs triage bug Something isn't working labels Jan 25, 2023
@szaimen szaimen transferred this issue from nextcloud/server Jan 25, 2023
@julien-nc
Copy link
Member

This issue can't be reproduced using server's master branch + Text's master. So Nextcloud 26 will definitely fix this.

We are investigating about the differences in 25 that could cause this issue.

@kaystrobach
Copy link
Author

25.0.3 was just released, will check with that version again, maybe a problem with an earlier version.

@julien-nc
Copy link
Member

julien-nc commented Feb 13, 2023

I spotted a relevant difference between NC 25 and 26:

  • In NC 25 (current stable25), the files:navigation:changed event is not emitted on the NC event bus when clicking on a directory while being in the favorites view (when getting out of the favorites view).
  • It is emitted in NC 26 (current master).

Text reacts to this event to update the rich workspace visibility.
IMHO emitting the files:navigation:changed in Files is the way to solve this issue.

I managed to make this work with nextcloud/server#36683 which is not the right way to go.
@skjnldsv @juliushaertl Any idea how to properly fix this?

@juliusknorr
Copy link
Member

Commented in the server PR ;)

@kaystrobach
Copy link
Author

Will this be backported to 24 EE?

@juliusknorr
Copy link
Member

As this is fixed on master and supported community versions I'll close this one.

@kaystrobach Feel free to reach out through the enterprise support channel for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants