Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 requires both annotation and attribute to create secured link #40

Closed
forgie1 opened this issue Dec 8, 2022 · 4 comments · Fixed by #42
Closed

PHP 8 requires both annotation and attribute to create secured link #40

forgie1 opened this issue Dec 8, 2022 · 4 comments · Fixed by #42

Comments

@forgie1
Copy link
Contributor

forgie1 commented Dec 8, 2022

see this commit: 752ad93
@hrach
Copy link
Member

hrach commented Dec 8, 2022

I'm really sorry, I did a poor review job. Plz @haltuf

@forgie1 forgie1 mentioned this issue Dec 8, 2022
Closed
@forgie1
Copy link
Contributor Author

forgie1 commented Dec 8, 2022

@hrach should be fixed by #41

@haltuf haltuf mentioned this issue Dec 8, 2022
Merged
@haltuf
Copy link
Contributor

haltuf commented Dec 8, 2022 •
edited
Loading

@hrach It is me, who is really sorry. Especially, when the tests of previous PR showed the error clearly - I just did not notice it.

@hrach hrach closed this as completed in #42 Dec 8, 2022
@hrach
Copy link
Member

hrach commented Dec 8, 2022

Thank you for reporting this. Closed in #42 and released as 1.10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hrach @haltuf @forgie1