Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] RO-Crate Export - Data files in Study not linked via hasPart #484

Closed
floWetzels opened this issue Jan 21, 2025 · 2 comments
Closed

[BUG] RO-Crate Export - Data files in Study not linked via hasPart #484

floWetzels opened this issue Jan 21, 2025 · 2 comments
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@floWetzels
Copy link
Collaborator

If a Study contains data files, these have a corresponding File entry in the exported RO-Crate. However, they are only linked to via the result property of the LabProcess objects in the process sequence. They should be linked via the hasPart property of the Dataset object corresponding to the Study (as is the case for assays). Therefore, the resulting json object is not a valid RO-Crate.
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jan 21, 2025
@floWetzels floWetzels mentioned this issue Jan 22, 2025
Merged
@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Jan 23, 2025
@HLWeil
Copy link
Member

HLWeil commented Jan 23, 2025

Can be closed? @floWetzels

@floWetzels
Copy link
Collaborator Author

Fixed by PR #488

@github-project-automation github-project-automation bot moved this to Done in ARCStack Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
ARCStack
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HLWeil @floWetzels