Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ad placeholder from the Google Publisher Console are not deleted when the component is unmounted #35

Open
getkey opened this issue Jul 26, 2017 · 2 comments

Comments

@getkey
Copy link

getkey commented Jul 26, 2017

When the Google Publisher Console is open on a page with ads, if the Bling get unmounted the yellow ad placeholder stays displayed.
screenshot from 2017-07-26 16-15-32

The ad seems to be properly removed though because it does not appear in the bottom panel of the Google Console. :-)

@potench
Copy link
Contributor

potench commented Jul 29, 2017

My guess is GPC is not rendered inside Bling. You could query select and remove the GPC DOM wrapper or call some GPC destroy method... Id execute it only if I found the feature flag for ?goog_fc or whatever the flag is to turn it on.

@potench
Copy link
Contributor

potench commented Jul 29, 2017

That should be pretty straight forward if you figure out the wrapping div or if the console comes with an API to destroy itself. PR it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants