Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) upgrade to react 16 #60

Merged
merged 1 commit into from
Nov 9, 2017
Merged

(refactor) upgrade to react 16 #60

merged 1 commit into from
Nov 9, 2017

Conversation

potench
Copy link
Contributor

@potench potench commented Nov 1, 2017

Goal:

Update to allow React 16 as a peerDependency.

Changes:

  1. react 16 as a peerDependency
  2. react 16 as a devDependency with all tests passing.
  3. tests should still pass with react 15
  4. using react-test-renderer for ShallowRenderer tests now

Notes

  1. Replaces Allow React 16 #57
  2. To test against React 15, first update package.json: devDependency, reminstall node_modules, then npm run test
// 1. manually update "package.json: devDependency" 
"react": "^15.0.1",
"react-dom": "^15.0.1",

@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files           8        8           
  Lines         580      580           
=======================================
  Hits          539      539           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d05a2b...c18cc06. Read the comment docs.

@potench potench merged commit 84264e7 into master Nov 9, 2017
@potench potench mentioned this pull request Nov 9, 2017
@potench potench deleted the feature/react-16 branch November 9, 2017 01:10
@potench potench mentioned this pull request Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants