Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-3 in njs_string.c #363

Closed
wants to merge 1 commit into from
Closed

Fix off-by-3 in njs_string.c #363

wants to merge 1 commit into from

Commits on Dec 22, 2020

  1. Fix off-by-one in njs_string.c 

    TL;DR: The `base64url` string is of len 9 but we compared only its first 6 bytes.

This was found with a "cstrnfinder" research and I haven't tested this change (more info https://twitter.com/disconnect3d_pl/status/1339757359896408065). Close this PR if this change is incorrect.
    @disconnect3d
    disconnect3d authored Dec 22, 2020
    Configuration menu
    Copy the full SHA
    7d679cd View commit details
    Browse the repository at this point in the history