Skip to content
This repository has been archived by the owner on May 27, 2020. It is now read-only.

is this ready? #173

Open
bboydflo opened this issue Feb 19, 2020 · 6 comments
Open

is this ready? #173

bboydflo opened this issue Feb 19, 2020 · 6 comments

Comments

@bboydflo
Copy link

Hi, thanks for this package. I am looking forward to use it but last time I checked ngxs website wasn't listed in there so I am not sure if it's ready to be used.

Also, it would be nice to know if I have other questions, where is the best way to ask them?

@splincode
Copy link
Member

Sorry, not production ready :(

@markwhitfeld
Copy link
Member

Contributions welcome though?

@jcheenatcode
Copy link

Would like to help. Was there something particular that you guys were planning to achieve in the next few weeks. Or was there a particular feature that you were trying to achieve for the next release. Or may be future releases or just fixing issues?

@splincode
Copy link
Member

@jcheenatcode I decided to completely switch to the development of another plugin, where the testing functionality will be included

https://github.com/ngxs-labs/data/blob/master/docs/pages/testing.md

If you want help, you can

@jcheenatcode
Copy link

@jcheenatcode I decided to completely switch to the development of another plugin, where the testing functionality will be included

https://github.com/ngxs-labs/data/blob/master/docs/pages/testing.md

If you want help, you can

@splincode thanks, is this going to be

  • part of the core ngxs/store
  • or the ngxs-labs/data
  • or is it that in future we will have to use the ngxs-labs/data for the purpose of testing?

the reason for the ask is, I don't recall me using the ngxs-labs/data anywhere in my project, so just thinking if I will have to install this going forward just for the purpose of testing?

@splincode
Copy link
Member

This @ngxs-labs/data plugin is integrated with its own testing solution.

@StateRepository()
@State({
  name: 'hello',
  default: 'HELLO_WORLD'
})
@Injectable()
export class HelloWorldState extends NgxsDataRepository<string> {}

it('expose state', ngxsTestingPlatform([ HelloWorldState ], (_, state) => {
   expect(state.getState()).toEqual('HELLO_WORLD')
}))

And not suitable for routine state testing

As for the current @ngxs-labs/testing plugin, I don’t deal with it anymore, you can send PR.

is this going to be

part of the core ngxs/store - NO
or is it that in future we will have to use the ngxs-labs/data for the purpose of testing? - testing only if you use @StateRepository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants