NH-3990 - Upgrade to VS2017 project structure #605

hazzik · 2017-04-25T08:26:17Z

No description provided.

hazzik · 2017-04-25T09:23:03Z

Doesn't seem to be buildable on a build agent without installing full VS

fredericDelaporte · 2017-04-25T11:21:22Z

The error in TeamCity does not let me think it needs a full VS. That looks like Antlr3 build is trying to use an old MsBuild dependency, and can no more find it when launched by the newest tools.

C:\Windows\system32\config\systemprofile\.nuget\packages\antlr3\3.5.1\build\Antlr3.targets(126,5): error MSB4062: The "Antlr3.Build.Tasks.AntlrClassGenerationTask" task could not be loaded from the assembly C:\Windows\system32\config\systemprofile\.nuget\packages\antlr3\3.5.1\build\.\AntlrBuildTask.dll. Could not load file or assembly 'Microsoft.Build.Utilities.v3.5, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

It seems to fail because it has a dependency on the old Microsoft.Build.Utilities.v3.5. I do not think having a full VS would avoid that failure. Enabling .NET Framework 3.5 feature on windows is supposed to provide it. The build agent seems to have it. So it looks more like the new build command is unable to resolve all the required dependencies.

hazzik · 2017-04-25T11:45:18Z

There are a few issues:

BuildTools does not know how to build the Sdk projects and so there is "Microsoft.NET.Sdk is missing" error (Tracking: .NET Core Sdk in Build Tools Installer dotnet/msbuild#1697)
If you specify MSBuildSDKsPath there is an error about VB projects saying that Restore task does not exist. (This way it does not build on my machine as well)
If you put dotnet msbuild %* as suggested you get this Antlr3 error (which I get on my machine as well)

There is another workaround - to copy the Sdk folder from VS to BuildTools, but I don't want to do it.

So yes, it's not buildable in the current state without full VS

fredericDelaporte · 2017-04-25T11:46:58Z

I have found this which looks related. If this is the root of our failure, we then have either to wait for the dotnet sdk to get fixed, or upgrade all build tasks for using newer msbuild, or avoid having parts to build with older msbuild.

I am not sure but I believe the only option we can do ourselves is the last, by reverting 9292e6e by example.

hazzik · 2017-04-25T12:09:39Z

I've filed a bug: antlr/antlrcs#71

fredericDelaporte

Getting from Package Manager output on solution opening:

Error occurred while restoring NuGet packages: The operation failed as details for project NHibernate.TestDatabaseSetup could not be loaded.
Error occurred while restoring NuGet packages: The operation failed as details for project NHibernate.TestDatabaseSetup could not be loaded.
Restoring NuGet packages...
Time Elapsed: 00:00:02.3618731
========== Finished ==========

I have not found a reason for this. Some bugs in VS was reported with that error but they are supposed to be fixed in latest updates, which I have.

It does not prevent compiling from within VS.

The bat build menu is broken:

Option D is unable to find TestDatabaseSetup, it has moved to a net461 subfolder.
Option E, F, G & I fail building.

Error log removed, see Alexander answer for fix.

It seems that switching back to another branch requires to close VS, purge obj folders, then reopen the solution. Otherwise it fails compiling and VS still display the dependencies as if the project were migrated to new csproj format.

fredericDelaporte · 2017-08-03T16:28:50Z

src/NHibernate.TestDatabaseSetup/NHibernate.TestDatabaseSetup.csproj

  <ItemGroup>
    <Reference Include="FirebirdSql.Data.FirebirdClient">
      <HintPath>..\..\lib\teamcity\firebird\FirebirdSql.Data.FirebirdClient.dll</HintPath>
    </Reference>
+    <Reference Include="Mono.Security">
+      <HintPath>..\..\lib\teamcity\postgresql\Mono.Security.dll</HintPath>
+    </Reference>


Strange addition, and missing file. Maybe a remnant from older Npgsql, no more needed.

Yes, probably a rebate glitch

hazzik · 2017-08-03T20:53:25Z

Yes, it requires either a clean checkout or purge of obj folders. Also it requires SDK2.0 Preview 2 and, possible, VS2017.3 Preview 6 (check without the VS first).

hazzik · 2017-08-03T21:43:20Z

NHibernate.TestDatabaseSetup could not be loaded.

Probably because of Mono.Security

fredericDelaporte · 2017-08-03T22:05:32Z

E, F, G & I builds fixed by the Core preview. (I have still the non preview VS2017.)

The Nuget difficulties for TestDatabaseSetup remains. Trying to build anything while Nuget struggles with TestDatabasSetup just fails, whatever the project. So it is a bit annoying, but well, not blocking either.
No, Mono.Security does not seem implied into this. I have tested that by removing it, that trouble is still there.

D still fails, if projects bin directories were cleaned before rebuilding with the new project format. (Otherwise it uses obsolete binaries from compilation with older project format.)

2.0 release is slated for Q3, so we will have to wait up to two months for the official release. Do you want to merge a dependency on a preview in master, or to wait for it to be released?

The new project format seems detrimental for VS load time of the solution. But without working with it and many branches, I cannot say if it will really be an annoyance. (And I still have R# enabled, which has also quite an impact on solution loading time.)

hazzik · 2017-08-03T22:20:54Z

D still fails

I did not realize that it requires to have binaries built by VS to run tests. Weird.

Do you want to merge a dependency on a preview in master, or to wait for it to be released?

I want to merge, don't mind being dependent on preview. It's just a dev dependency, so does not matter much.

hazzik · 2017-08-03T22:31:36Z

I've fixed "D" menu to the state as it was before this PR.

It requires to have Tools folder packages restored & binaries being built by VS. I think we shall tackle this in a separate PR.

fredericDelaporte · 2017-08-03T23:03:15Z

I did not realize that it requires to have binaries built by VS to run tests. Weird.

I was aware of this, and am using it for globally testing the last build I have done in VS. I was thinking this was made this way on purpose.

I want to merge, don't mind being dependent on preview. It's just an dev dependency, so does not matter.

Ok; Contributing.md should probably be updated for mentioning the build dependency on Core 2.0 (Preview or not indeed).

fredericDelaporte · 2017-08-03T23:12:38Z

NHibernate.nunit

-    <assembly path="src\NHibernate.Test.VisualBasic\bin\Debug\NHibernate.Test.VisualBasic.dll" />
+    <assembly path="src\NHibernate.TestDatabaseSetup\bin\Debug\net461\NHibernate.TestDatabaseSetup.dll" />
+    <assembly path="src\NHibernate.Test\bin\Debug\net461\NHibernate.Test.dll" />
+    <assembly path="src\NHibernate.Test.VisualBasic\bin\Debug\net461\NHibernate.Test.VisualBasic.dll" />


VB has not moved. It is still in NHibernate.Test.VisualBasic\bin\Debug\NHibernate.Test.VisualBasic.dll.

True. VB has not been migrated to VS2017 format as it is supported only in VS2017.3

I was not knowing it would be supported for VB soon. I was not finding any info about vb support case, so was not expecting it at all.

It is, I saw somewhere on SO, but could not find the link now.

fredericDelaporte · 2017-08-03T23:12:45Z

NHibernate.nunit

-    <assembly path="src\NHibernate.Test.VisualBasic\bin\Release\NHibernate.Test.VisualBasic.dll" />
+    <assembly path="src\NHibernate.TestDatabaseSetup\bin\Release\net461\NHibernate.TestDatabaseSetup.dll" />
+    <assembly path="src\NHibernate.Test\bin\Release\net461\NHibernate.Test.dll" />
+    <assembly path="src\NHibernate.Test.VisualBasic\bin\Release\net461\NHibernate.Test.VisualBasic.dll" />


Same as above.

- use dotnet to build solution - fix typo in TestEmbeddedConfig.cfg.xml name - fix extension of EntityWithFilters.hbm.xml

ngbrown · 2017-08-07T05:33:24Z

src/NHibernate.Tool.HbmXsd/NHibernate.Tool.HbmXsd.csproj

-    <BootstrapperEnabled>true</BootstrapperEnabled>
-    <TargetFrameworkProfile>
-    </TargetFrameworkProfile>
+    <TargetFramework>net461</TargetFramework>


To output an .EXE, the following needs to be added:

<OutputType>Exe</OutputType> <StartupObject>NHibernate.Tool.HbmXsd.Program</StartupObject>

Created pull request #672

hazzik force-pushed the NH-3990 branch 2 times, most recently from bb37ad0 to d38b027 Compare April 25, 2017 08:42

hazzik closed this Apr 25, 2017

hazzik reopened this Aug 2, 2017

hazzik force-pushed the NH-3990 branch 9 times, most recently from af8e784 to 13bcd26 Compare August 3, 2017 05:58

hazzik requested a review from fredericDelaporte August 3, 2017 12:47

fredericDelaporte reviewed Aug 3, 2017

View reviewed changes

hazzik force-pushed the NH-3990 branch from 13bcd26 to 667d6b8 Compare August 3, 2017 21:48

hazzik force-pushed the NH-3990 branch from 667d6b8 to be769c2 Compare August 3, 2017 22:30

hazzik modified the milestone: 5.0 Aug 3, 2017

fredericDelaporte reviewed Aug 3, 2017

View reviewed changes

hazzik force-pushed the NH-3990 branch from be769c2 to e2d54bd Compare August 3, 2017 23:16

fredericDelaporte previously approved these changes Aug 3, 2017

View reviewed changes

hazzik added the t: Improvement label Aug 3, 2017

hazzik mentioned this pull request Aug 4, 2017

NH-4064 - Unmerge Antlr3.Runtime #668

Merged

hazzik dismissed fredericDelaporte’s stale review via fddfb2f August 5, 2017 05:47

hazzik force-pushed the NH-3990 branch from e2d54bd to fddfb2f Compare August 5, 2017 05:47

NH-3990 - Upgrade to VS2017 project structure

ea51355

- use dotnet to build solution - fix typo in TestEmbeddedConfig.cfg.xml name - fix extension of EntityWithFilters.hbm.xml

hazzik force-pushed the NH-3990 branch from fddfb2f to ea51355 Compare August 5, 2017 05:49

hazzik merged commit ea51355 into nhibernate:master Aug 5, 2017

hazzik added the r: Fixed label Aug 5, 2017

ngbrown mentioned this pull request Aug 6, 2017

NH-3990 - Upgrade VB test project to VS2017 project structure #670

Merged

hazzik deleted the NH-3990 branch August 6, 2017 22:54

ngbrown reviewed Aug 7, 2017

View reviewed changes

ngbrown mentioned this pull request Aug 10, 2017

NH-3990 - Fixes for upgrade to VS2017 project structure #672

Merged

fredericDelaporte mentioned this pull request Sep 17, 2017

Doc fixes #690

Merged

nhibernate-bot mentioned this pull request Oct 12, 2017

NH-3807 - Support for .NET Core 2.0 #954

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NH-3990 - Upgrade to VS2017 project structure #605

NH-3990 - Upgrade to VS2017 project structure #605

hazzik commented Apr 25, 2017

hazzik commented Apr 25, 2017

fredericDelaporte commented Apr 25, 2017

hazzik commented Apr 25, 2017 •

edited

Loading

fredericDelaporte commented Apr 25, 2017

hazzik commented Apr 25, 2017 •

edited

Loading

fredericDelaporte left a comment •

edited

Loading

fredericDelaporte Aug 3, 2017

hazzik Aug 3, 2017

hazzik commented Aug 3, 2017

hazzik commented Aug 3, 2017

fredericDelaporte commented Aug 3, 2017 •

edited

Loading

hazzik commented Aug 3, 2017 •

edited

Loading

hazzik commented Aug 3, 2017 •

edited

Loading

fredericDelaporte commented Aug 3, 2017

fredericDelaporte Aug 3, 2017 •

edited

Loading

hazzik Aug 3, 2017

hazzik Aug 3, 2017

fredericDelaporte Aug 3, 2017 •

edited

Loading

hazzik Aug 3, 2017

fredericDelaporte Aug 3, 2017

ngbrown Aug 7, 2017 •

edited

Loading

ngbrown Aug 10, 2017

NH-3990 - Upgrade to VS2017 project structure #605

NH-3990 - Upgrade to VS2017 project structure #605

Conversation

hazzik commented Apr 25, 2017

hazzik commented Apr 25, 2017

fredericDelaporte commented Apr 25, 2017

hazzik commented Apr 25, 2017 • edited Loading

fredericDelaporte commented Apr 25, 2017

hazzik commented Apr 25, 2017 • edited Loading

fredericDelaporte left a comment • edited Loading

Choose a reason for hiding this comment

fredericDelaporte Aug 3, 2017

Choose a reason for hiding this comment

hazzik Aug 3, 2017

Choose a reason for hiding this comment

hazzik commented Aug 3, 2017

hazzik commented Aug 3, 2017

fredericDelaporte commented Aug 3, 2017 • edited Loading

hazzik commented Aug 3, 2017 • edited Loading

hazzik commented Aug 3, 2017 • edited Loading

fredericDelaporte commented Aug 3, 2017

fredericDelaporte Aug 3, 2017 • edited Loading

Choose a reason for hiding this comment

hazzik Aug 3, 2017

Choose a reason for hiding this comment

hazzik Aug 3, 2017

Choose a reason for hiding this comment

fredericDelaporte Aug 3, 2017 • edited Loading

Choose a reason for hiding this comment

hazzik Aug 3, 2017

Choose a reason for hiding this comment

fredericDelaporte Aug 3, 2017

Choose a reason for hiding this comment

ngbrown Aug 7, 2017 • edited Loading

Choose a reason for hiding this comment

ngbrown Aug 10, 2017

Choose a reason for hiding this comment

hazzik commented Apr 25, 2017 •

edited

Loading

hazzik commented Apr 25, 2017 •

edited

Loading

fredericDelaporte left a comment •

edited

Loading

fredericDelaporte commented Aug 3, 2017 •

edited

Loading

hazzik commented Aug 3, 2017 •

edited

Loading

hazzik commented Aug 3, 2017 •

edited

Loading

fredericDelaporte Aug 3, 2017 •

edited

Loading

fredericDelaporte Aug 3, 2017 •

edited

Loading

ngbrown Aug 7, 2017 •

edited

Loading