Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to protobuf v5 #677

Open
dixonjoel opened this issue Mar 25, 2024 · 0 comments
Open

Update to protobuf v5 #677

dixonjoel opened this issue Mar 25, 2024 · 0 comments
Labels
triage New issue that needs to be reviewed user story A small chunk of work to be done

Comments

@dixonjoel
Copy link
Collaborator

dixonjoel commented Mar 25, 2024

User Story

Mend renovate PR to update to protobuf v5 failed.

Updating dependencies
Resolving dependencies...

Creating virtualenv ni-measurementlink-service in /tmp/renovate/repos/github/ni/measurementlink-python/.venv

Because no versions of nidaqmx match >0.8.0,<0.9.0 || >0.9.0
 and nidaqmx (0.8.0) depends on protobuf (>=4.21,<5.0), nidaqmx (>=0.8.0,<0.9.0 || >0.9.0) requires protobuf (>=4.21,<5.0).
And because nidaqmx (0.9.0) depends on protobuf (>=4.21,<5.0), nidaqmx (>=0.8.0) requires protobuf (>=4.21,<5.0).
So, because ni-measurementlink-service depends on both protobuf (^5.0.0) and nidaqmx (>=0.8.0), version solving failed.

"We should be careful about how we update measurementlink-python, nidaqmx-python, and nimi-python, to avoid shipping modules that are incompatible with each other." (From this Teams thread)

Steps needed:

  • figure out what grpcio's version constraint will be
  • coordinate upgrade across nimi-python, nidaqmx-python, and measurementlink-python
    if grpcio allows v4 or v5, you can upgrade all 3 at your leisure
    if grpcio only allows v5, all 3 must upgrade in lock-step

AB#2692024

@dixonjoel dixonjoel added user story A small chunk of work to be done triage New issue that needs to be reviewed labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issue that needs to be reviewed user story A small chunk of work to be done
Projects
None yet
Development

No branches or pull requests

1 participant