New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Register Pin Map API to Measurement Client #871

Merged

MounikaBattu17 merged 38 commits into main from users/mounika/client-register-pinmap

Sep 13, 2024

Contributor

MounikaBattu17 commented Sep 2, 2024 •

edited

Loading

This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Adds register_pin_map API to measurement client.
Implements Task 2827581: Add register_pin_map API.

Why should this Pull Request be merged?

Added register_pin_map and its usage in mako template.
Added automated tests with new pin aware measurement.
Added test assets accordingly.

What testing has been done?

Added automated tests

MounikaBattu17 added 2 commits

September 2, 2024 16:38


          Feat: Add register pin map API in measurement client

56476ff


          Feat: Add automated tests

6f7c71a

MounikaBattu17 requested review from csjall, dixonjoel, bkeryan, mshafer-NI and nstokes-nati as code owners

September 2, 2024 11:13

github-actions bot commented Sep 2, 2024 •

edited

Loading

Test Results

30 files ±0 30 suites ±0 36m 59s ⏱️ -44s
651 tests ±0 651 ✅ ±0 0 💤 ±0 0 ❌ ±0
16 130 runs ±0 15 060 ✅ ±0 1 070 💤 ±0 0 ❌ ±0

Results for commit c5d0adb. ± Comparison against base commit 6d75114.

♻️ This comment has been updated with latest results.

MounikaBattu17 requested review from jayaseelan-james and Avinash2Suresh

September 2, 2024 12:03

MounikaBattu17 changed the title ~~Added Register Pin Map API to Measurement Client~~ [Internal] Added Register Pin Map API to Measurement Client

Avinash2Suresh reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

MounikaBattu17 added 2 commits

September 2, 2024 21:13


          Tests: Param name change

cfd1079


          Refractor: Make global vars as class members

45df3f0

jayaseelan-james requested changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_pin_aware_measurement_client.py Show resolved Hide resolved

MounikaBattu17 changed the title ~~[Internal] Added Register Pin Map API to Measurement Client~~ Added Register Pin Map API to Measurement Client

MounikaBattu17 added 3 commits

September 3, 2024 19:01


          Fix: Remove unused constants

26c8926


          Refractor: pin_map_path setter

fb9fbaa


          Tests: Removed unwanted asserts

0e2ad93

Avinash2Suresh reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved


          Revert: Assert removal

Collaborator

dixonjoel commented Sep 4, 2024

@mshafer-NI Brad is out until next Wednesday. So if you have some time while he's out to also review these PRs for Python correctness / style, that would be great.


          Refractor: Make public vars and add cached property

aae7426

MounikaBattu17 requested a review from jayaseelan-james

September 4, 2024 17:46

dixonjoel approved these changes

View reviewed changes

mshafer-NI reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

mshafer-NI reviewed

View reviewed changes

packages/generator/tests/acceptance/test_pin_aware_measurement_client.py Show resolved Hide resolved

jayaseelan-james reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

Avinash2Suresh approved these changes

View reviewed changes

bkeryan requested changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_pin_aware_measurement_client.py Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/test_assets/example_renders/pin_map/1Smu1ChannelGroup1Pin1Site.pinmap Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

MounikaBattu17 added 7 commits

September 11, 2024 00:25


          Client: Change pin map path from str to path type

2967a1c


          Client: Add pin map context getter setter

d970d7d


          Client: Add conditional parameterization to measure request

243febd


          Client: Remove unused imports

b19f8cc


          Merge branch 'main' into users/mounika/client-register-pinmap

e2c0819


          Tests: Update tests with mako changes

609d85f


          Fix: Use named tuple PinMapContext

efd5a73

MounikaBattu17 requested a review from bkeryan

September 11, 2024 08:34

MounikaBattu17 added 2 commits

September 11, 2024 14:45


          Refractor: Sites setter

1011d57


          Fix: Add type hints

aa28038

bkeryan requested changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Show resolved Hide resolved

...st_assets/example_renders/measurement_plugin_client/non_streaming_data_measurement_client.py Outdated Show resolved Hide resolved

MounikaBattu17 added 5 commits

September 12, 2024 02:35


          Refractor: Measure request constructor

b643309


          Client: Raise TypeError instead of ValueError

42de178


          Fix: pin map context tuple replace issue

ff1ea89


          Client: Add docstring for sites property

8578e03


          Client: Add docstring to sites

8f545a7

MounikaBattu17 requested a review from bkeryan

September 11, 2024 22:47

bkeryan approved these changes

View reviewed changes

Collaborator

bkeryan left a comment

Approved with suggestions (include invalid type in error message)

MounikaBattu17 added 2 commits

September 13, 2024 09:45


          Refractor: Add type in error message

ee362f9


          Merge branch 'main' into users/mounika/client-register-pinmap

c5d0adb

jayaseelan-james reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_pin_aware_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_pin_aware_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_pin_aware_measurement_client.py Outdated Show resolved Hide resolved

MounikaBattu17 added 3 commits

September 13, 2024 19:32


          Fix: Docstrings clarity

59eeaae


          Tests: Update test cases

e1145ed


          Merge branch 'main' into users/mounika/client-register-pinmap

c9920aa

MounikaBattu17 merged commit d67c244 into main

15 checks passed

jayaseelan-james deleted the users/mounika/client-register-pinmap branch

September 13, 2024 14:36

jayaseelan-james mentioned this pull request

[High Priority] Fix Path type conversion and type hints for client codegen #931

Merged

1 task

jayaseelan-james mentioned this pull request

Clean up the unused build_in_import_modules dictionary in ni-measurement-plugin-client-generator #979

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jayaseelan-james jayaseelan-james approved these changes

dixonjoel dixonjoel approved these changes

mshafer-NI mshafer-NI left review comments

bkeryan bkeryan approved these changes

Avinash2Suresh Avinash2Suresh approved these changes

csjall Awaiting requested review from csjall csjall is a code owner

nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Jotheeswaran-Nandagopal Awaiting requested review from Jotheeswaran-Nandagopal

Labels

None yet