Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions Workflows should be updated to use Node.js 20 #2039

Open
ni-jfitzger opened this issue Feb 9, 2024 · 2 comments
Open

Github Actions Workflows should be updated to use Node.js 20 #2039

ni-jfitzger opened this issue Feb 9, 2024 · 2 comments

Comments

@ni-jfitzger
Copy link
Collaborator

Description of issue

Our nimibot runner summaries are showing annotations:

system_test (niscope)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

We should update our configuration to use Node.js 20, before support for Node.js 16 is dropped entirely.

The configuration for this can be found in .github\workflows\github_actions_aws_*.yml (the * is a wildcard not part of a filename).
The steps look like:

    steps:
      - name: checkout repository
        uses: actions/checkout@v3
      - name: upload coverage
        uses: codecov/codecov-action@v3
  • For codecov-action, the issue was addressed in the v4 release
    • Arguments to the action have changes, so see the README
    • There's some mixed messaging that suggests we could go back to Tokenless uploading (PRs made from forks to the upstream public repos will support tokenless), but based on my reading of things, I don't think that's the case. It'll give us intermittent upload failures, again
  • For checkout, the issue was addressed in the v4 release
@ni-jfitzger ni-jfitzger added this to the nimi-python 1.4.8 milestone Feb 9, 2024
@bkeryan
Copy link
Contributor

bkeryan commented Feb 9, 2024

@ni-jfitzger Consider using the Mend Renovate app to keep your GitHub actions and Poetry lock files up-to-date. Here is the config we've been using in measurementlink-python: https://github.com/ni/measurementlink-python/blob/main/.github/renovate.json

It automatically posts PRs for dependency updates and you can configure scheduling and auto-merging if you want. It also creates a "Dependency Dashboard" issue that you can use to see its status and control it: https://www.github.com/ni/measurementlink-python/issues/475

@ni-jfitzger
Copy link
Collaborator Author

@bkeryan That sounds very useful. I'll create an issue under our Streamlined Processes milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants