-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotenv #14
Comments
This is now completed for Vagrant, Puppet, and Gulp (they're all sharing a common |
This seems like a good approach without requiring Composer. However, it would result in essentially 2 very similar config files. |
Another possibility would be to include the full version of makeItCraft - the full version installs dotenv as well (it does make Composer a dependency, though, but it handles the initial setup). I only used the "install Craft" part of it because the dotenv bit added complexity that we weren't planning on using at the time, but it might be worth trying now there is a At the time I asked Matt Stauffer (who wrote makeItCraft) for permission to include it, and he said that was fine, so I think it should be ok to add the rest of it if needed. |
Having config settings (eg. database credentials, site URL) in a
.env
file would not only potentially make multiple environment handling more elegant for Craft (see this), but could actually be shared by both Vagrant and Gulp (to, eg. avoid havingcraft.dev
hard-coded as the server name anywhere)The text was updated successfully, but these errors were encountered: