Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestep arg does not do anything #1

Open
n00mkrad opened this issue Jul 20, 2022 · 5 comments
Open

Timestep arg does not do anything #1

n00mkrad opened this issue Jul 20, 2022 · 5 comments

Comments

@n00mkrad
Copy link

Same issue as in rife-ncnn-vulkan.

Changing timestep argument does not have any effect.

@nihui
Copy link
Owner

nihui commented Jul 21, 2022

Vimeo90K models can only do 0.5 timestamp interpolation.

GoPro models can do arbitrary timestamp interpolation.

@Hudaldadi
Copy link

Hudaldadi commented Jul 21, 2022

it works - the GoPro models are not as impressive like Vimeo ones.

Thank sooooooo much for sharing Your great work *
It works fantastic on Mac OSX!

@n00mkrad
Copy link
Author

Vimeo90K models can only do 0.5 timestamp interpolation.

GoPro models can do arbitrary timestamp interpolation.

I know, but the -s argument does not work, even when using the GoPro models. -s 0.25 will do 2x interpolation instead of 4x.

@Hudaldadi
Copy link

maybe the -s argument is only choosing the position in time and does not generate more frames.

@NeedsMoar
Copy link

No, the code is just broken. When processing an entire directory, it always uses numframes / the count of files to control this. You need to specify how many frames you want and it should work. OTOH when only passing in single files only the timestep argument does anything. As clear as the -tta flag that all the upscalers provide with no documentation which sometimes lowers quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants