Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values in WHERE conditions are returned as 'NULL' when they shouldn't #124

Open
adrienlabelle opened this issue Oct 20, 2021 · 1 comment

Comments

@adrienlabelle
Copy link

adrienlabelle commented Oct 20, 2021

protected function writeNullSqlString($value)

This piece of code will replace the following tested values with 'NULL': '0', ''. which is incorrect. A NOT NULL column could be set to an empty string or a VARCHAR column can be set to '0' for example. IMHO the only valid mapping for 'NULL' is the null type.

@pthreat
Copy link

pthreat commented Sep 19, 2022

I found this problem too, this is the reason why I forked this library to fix said issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants