fix: menu options z-index (#402) #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ninjakit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thank you for this fix. I'm merging as-is, then investigating whether it is feasible to layer dom elements by the order of their containing parents to do away with z-indexing altogether. Seems like either this or an intentional system of units like the one you proposed are a good overall change. |
|
🎉 This PR is included in version 1.14.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Awesome, no problem. Thanks Jamie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be ideal, but it's a start.
We may want to consider a wider range of
z-indexes for more flexibility. In other words, higher-numberedz-indexes with space in between, just in case. For example,Dialogs could be at 10,Menuat 20, etc, similar to how Bootstrap does it.