Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests leaving behind processes #74

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Conversation

edivados
Copy link
Contributor

@edivados edivados commented Dec 31, 2023

This fixes two things.

Too many symbolic links

pnpm scanning test/.fixtures and complaining about too many symbolic links.
Adding !**/.fixtures/** to pnpm-workspace did not work so I added /test and /test/templates/** instead.

Test runs leaving behind processes

proc.kill() not terminating process. To work around this scripts are now started with node.
Either there is a bug in npm or something is wrong here.

Copy link

codesandbox bot commented Dec 31, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Dec 31, 2023

⚠️ No Changeset found

Latest commit: 6e502d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2024 7:58pm

@nksaraf nksaraf merged commit 16814e6 into nksaraf:main Jan 1, 2024
6 checks passed
@edivados edivados deleted the fix-test-setup branch January 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants