Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed benchmark due to renamed branch #2796

Closed
grafail opened this issue Jun 1, 2021 · 0 comments · Fixed by #2795
Closed

Failed benchmark due to renamed branch #2796

grafail opened this issue Jun 1, 2021 · 0 comments · Fixed by #2795
Assignees
@nlohmann
Labels
kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.10.0

Comments

@grafail
Copy link
Contributor

grafail commented Jun 1, 2021 •
edited by nlohmann
Loading

The default branch in https://github.com/google/benchmark was renamed from "master" to "main", which breaks the cloning process during building the benchmark:
CMakeLists Original Source:

FetchContent_Declare(
    benchmark
    GIT_REPOSITORY https://github.com/google/benchmark.git
    GIT_SHALLOW TRUE
)

I created a fix for this which explicitly specifies using the main branch in #2795.
@grafail grafail changed the title Failed benchmark git clone issue Failed benchmark due to renamed branch Jun 5, 2021
@nlohmann nlohmann linked a pull request Jun 7, 2021 that will close this issue
Specified git branch for google benchmark fetch in benchmark test #2795
Merged
4 tasks
@nlohmann nlohmann self-assigned this Jun 7, 2021
@nlohmann nlohmann added this to the Release 3.9.2 milestone Jun 7, 2021
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.10.0
Development

Successfully merging a pull request may close this issue.

Specified git branch for google benchmark fetch in benchmark test turintech/json
2 participants
@nlohmann @grafail