Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow types and consider TypeScript bindings #167

Open
dantman opened this issue Apr 2, 2018 · 0 comments
Open

Add flow types and consider TypeScript bindings #167

dantman opened this issue Apr 2, 2018 · 0 comments
Milestone

Comments

@dantman
Copy link

dantman commented Apr 2, 2018

It would be nice to clean up the code a bit and add type bindings.

The plan is to use Flow types for the code itself. We will also export types for other flow users to use.

We will not write the code in TypeScript, but we may consider making TypeScript bindings available.

The question about TypeScript at the moment is primarily where to put them.

The official documentation recommends that packages not written in TypeScript publish types with DefinitelyTyped.

However I find that a lot of widely used libraries not written in .ts still distribute .flow and typescript definitions alongside their code.

However given that currently both @types/fb and @types/facebook-js-sdk both exist and both are for Facebook's client-side JavaScript SDK. It might be simpler to

Except types are going to get messy should we implement #152 and effectively wrap the types of the entire SDK that Facebook provides.

The goal is to use Flow internally support both Flow and TypeScript consumers. So #63 and #46 which only suggest TypeScript definitions and are out of date are obsolete discussions.

@dantman dantman added this to the 4.0.0 milestone Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant