-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update node-test-commit-v8-linux to not overwrite make-v8.sh with a local copy #1857
Comments
+1 if the file is the same. I had thought that @refack had upstreamed. |
Also TBD: The test-osuosl-ubuntu1404-ppc64 have copies of the pkg-config files in /home/iojs/build-tools/pkg-config-files, but the are identical to the system .pc files in |
see: nodejs/node#28458 |
https://ci.nodejs.org/job/node-test-commit-v8-linux/2396/nodes=centos7-ppcle,v8test=v8test/console Its actually building v8, that's promising, will take a while to know if it suceeds in the test. |
been more than a month with no complaints, must have worked. |
Follow on from #1536, cc @refack @mhdawson
https://ci.nodejs.org/job/node-test-commit-v8-linux/ is copying over make-v8.sh from a local copy, with a note about upstreaming the changes.
But @refack already upstreamed the changes.
I modified the job config to not do the copy, I'll see how it goes: https://ci.nodejs.org/job/node-test-commit-v8-linux/2391/
I don't want to carry this hack over onto the new centos7 ppcle machines.
The text was updated successfully, but these errors were encountered: