Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citgm builds with small-icu #1963

Closed
richardlau opened this issue Oct 16, 2019 · 2 comments
Closed

citgm builds with small-icu #1963

richardlau opened this issue Oct 16, 2019 · 2 comments

Comments

@richardlau
Copy link
Member

Just noticed while editing the job config for #1959 that the CITGM job explicitly sets CONFIG_FLAGS to build small-icu:

image

We've recently made full-icu the default for master and the upcoming 13.x but the above will build Node.js in a non-default mode and probably means the CITGM run for nodejs/node#29522 didn't actually test what we thought it did ☹️.

I'll remove the explicit set after #1959 is resolved (don't want to change multiple things at once).

FYI @nodejs/releasers @nodejs/citgm
@richardlau
Copy link
Member Author

We don't explicitly set any config flags in the job for Windows so we're okay there and its just (!) the UNIX/UNIX-like platforms.

@richardlau
Copy link
Member Author

Made the change: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/jobConfigHistory/showDiffFiles?timestamp1=2019-10-16_20-33-19&timestamp2=2019-10-16_20-35-51

Test run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2060/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richardlau